[Issue]: Offset pagination - Offset skips first entity

[chihabhajji]

Hello,

when using offset pagination it skips the first record in the database.

possible fixes are either allowing the offset to be 0 or using offset -1

[jiho-kr]

Hi @chihabhajji

I tried to check it through unit-test(#433), but I couldn't reproduce it.

Can you give me more information?

[chihabhajji]

Hello @jiho-kr , gladly, here is my database, it has one record for the purpose of this test

when i try the endpoint with 10 limit and offset 1 i get the following


the metadata has total 1 but the record is not returned.
and after i add a user and run the same query i get the following

this is my controller
typescript @ApiTags('users') @ApiBearerAuth() @ApiOAuth2(['email', 'profile']) @Crud({ entity: User, routes: { readMany: { relations: ['profile'], paginationType: 'offset', numberOfTake: 10, softDelete: false, sort: 'ASC', swagger: { response: DepopulatedUserInfoDTO, }, decorators: [ApiQuery({ name: 'role', type: String, enum: ERole })], exclude: ['password', '_id', 'deletedAt'], }, readOne: { exclude: ['password'], relations: ['profile', 'organizations', 'memberOrganizations'], swagger: { response: OmitType(User, ['password', 'deletedAt']), }, }, search: { relations: ['profile'], paginationType: 'offset', numberOfTake: 10, swagger: { response: DepopulatedUserInfoDTO, }, exclude: ['password', '_id', 'deletedAt'], }, }, only: [Method.READ_MANY, Method.READ_ONE, Method.UPDATE, Method.SEARCH], }) @Controller('users') export class UsersController { // noinspection JSUnusedLocalSymbols constructor(private readonly crudService: UsersService) {} }

[jiho-kr]

Hi, @chihabhajji

Because you set the offset to 1, the data is searched from the second time.
You should either not set offset or use 0.

This article might be helpful for you.

[chihabhajji]

Yes i am aware of that, thats why my issue title says allow offset to be 0, because 0 is not accepted

[jiho-kr]

aha I get it, i'll check 0 is not accepted

[chihabhajji]

[jiho-kr]

https://github.com/woowabros/nestjs-library-crud/releases/tag/0.10.2

[chihabhajji]

thank you ^^