Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zero downtime is a promise not held in reality: can you add a hook (so we can reload the proxy)? #23

Closed
Morriz opened this issue Feb 18, 2024 · 3 comments
Labels
duplicate This issue or pull request already exists

Comments

@Morriz
Copy link

Morriz commented Feb 18, 2024

Your solution is incurring downtime as it ignores the downstream proxy, which needs to reload to register the rolled out container's new ip address. AND it needs to reload RIGHT AFTER the rollout moment. Unfortunately your script's duration is too long and in the mean time the proxy still forwards traffic to the old ip.

So my suggestion is to get a hook for us to call the reload of the proxy.

@wowu wowu added the duplicate This issue or pull request already exists label Feb 18, 2024
@wowu
Copy link
Owner

wowu commented Feb 18, 2024

Thanks. You're right, and this problem is already tracked in #21, so I suggest moving the discussion there. I think we're go for the hook approach.

What the command in the hook would look like in your case? I need to know what parameters should be passed to the command in the hook, is container id enough? What proxy do you use?

Please respond in #21, I'll close this issue as a duplicate.

@wowu wowu closed this as completed Feb 18, 2024
@Morriz
Copy link
Author

Morriz commented Feb 21, 2024

Ah, great! I suggest to stay agnostic and let us provide a payload...we would want to specify something executable on the host like "docker compose exec proxy sh -c \'nginx -s reload'".

@Morriz
Copy link
Author

Morriz commented Feb 21, 2024

which your code would then execute that is...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants