Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in message formatter config #7556

Closed
vikumkbv opened this issue Jan 12, 2024 · 4 comments · Fixed by #7561
Closed

Error in message formatter config #7556

vikumkbv opened this issue Jan 12, 2024 · 4 comments · Fixed by #7561

Comments

@vikumkbv
Copy link

Hi Team,

In the documentation [1], we found a typo in the [[custom_message_formatters]] class, please correct is as follows.

Current version

[[custom_message_formatters]]
class = "org.wso2.carbon.relay.BinaryRelayBuilder"
content_type = "application/json/badgerfish"

[[custom_message_builders]]
class = "org.wso2.carbon.relay.BinaryRelayBuilder"
content_type = "application/json/badgerfish"

Corrected version

[[custom_message_formatters]]
class = "org.wso2.carbon.relay.ExpandingMessageFormatter"
content_type = "application/json/badgerfish"

[[custom_message_builders]]
class = "org.wso2.carbon.relay.BinaryRelayBuilder"
content_type = "application/json/badgerfish"

[1] https://apim.docs.wso2.com/en/latest/install-and-setup/setup/mi-setup/message_builders_formatters/message-builders-and-formatters/#handling-message-relay

Thanks,
Vikum

Mariangela added a commit to Mariangela/docs-apim that referenced this issue Jan 12, 2024
- Updated the code block based on the information provided in wso2#7556
- Made some formatting changes.
@Mariangela
Copy link
Contributor

Mariangela commented Jan 12, 2024

Assignees
@Mariangela

Status
In progress

@DinithiDiaz , I have fixed this issue in [1]. Please review and merge the PR.

@vikumkbv , I see this same mistake in APIM 4.1.0 and 4.0.0 as well. Is the fix that you mentioned applicable to APIM 4.1.0 and 4.0.0 as well?

[1] #7558

@DinithiDiaz
Copy link
Member

@DinithiDiaz , I have fixed this issue in [1]. Please review and merge the PR.

Hi @Mariangela, merged the PR.

@DinithiDiaz
Copy link
Member

Sent fixes via wso2/docs-mi#69 and wso2/docs-mi#70 to update the MI 4.2.0 documentation.

@Mariangela
Copy link
Contributor

@DinithiDiaz , I am assuming that this fix is valid for 4.1.0 and 4.0.0 as well. Therefore, I made these changes in the master, 4.1.0 and 4.0.0 branches.

DinithiDiaz added a commit that referenced this issue Jan 22, 2024
DinithiDiaz added a commit that referenced this issue Jan 22, 2024
DinithiDiaz added a commit that referenced this issue Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants