Refactor rules feature with new rules execution object contract + eslint license header rule update to support 2025 #7300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## new-signup #7300 +/- ##
===========================================
Coverage 32.02% 32.02%
===========================================
Files 41 41
Lines 893 893
Branches 204 220 +16
===========================================
Hits 286 286
+ Misses 607 557 -50
- Partials 0 50 +50
Flags with carried forward coverage won't be shown. Click here to find out more. |
brionmario
reviewed
Jan 14, 2025
brionmario
reviewed
Jan 14, 2025
...in.registration-flow-builder.v1/components/element-property-panel/nodes/rules-properties.tsx
Show resolved
Hide resolved
brionmario
reviewed
Jan 14, 2025
brionmario
reviewed
Jan 14, 2025
|
|
||
| /** | ||
| * Method to get the context value | ||
| * | ||
| * @returns RuleInstanceData | ||
| */ | ||
| export const getRuleInstanceValue = () => RuleContextRef.ruleInstance; | ||
| export const getRuleInstanceValue = () => Object.freeze(RuleContextRef.ruleInstance); |
There was a problem hiding this comment.
We'll be moving to to a hook in the future right? Since the object is a nested object, Object.freeze wouldn't be ideal.
Shall we do a deep clone, if we are planning to keep exposing the instance directly.
WDYT?
Suggested change
| export const getRuleInstanceValue = () => Object.freeze(RuleContextRef.ruleInstance); | |
| export const getRuleInstanceValue = (): RuleExecuteCollectionInterface => Object.freeze(RuleContextRef.ruleInstance); |
brionmario
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject related to wso2/product-is#22423