jmxEnabled property is not templated for the identity db

[pabasara-mahindapala]

Description

The jmxEnabled property is not templated for the identity db in the master-datasources.xml.j2 file. Due to this jmxEanbled property has to be added under pool_options only for the identity db.

For consistency, this property should be templated for WSO2_IDENTITY_DB similar to WSO2_SHARED_DB, WSO2USER_DB and WSO2CONFIG_DB configurations. We have mentioned inconsistent configurations in the docs as well [1].

[1] https://is.docs.wso2.com/en/6.0.0/deploy/monitor/jmx-based-monitoring/#configuring-jmx-in-wso2-identity-server:~:text=Enabling%20JMX%20for%20a%20datasource

<datasource>
    <name>WSO2_SHARED_DB</name>
    <description>Shared Database for user and registry data</description>
    <jndiConfig>
        <name>jdbc/SHARED_DB</name>
    </jndiConfig>
    <definition type="RDBMS">
        <configuration>
            <url>{{database.shared_db.url}}</url>
            <username>{{database.shared_db.username}}</username>
            <password>{{database.shared_db.password}}</password>
            <driverClassName>{{database.shared_db.driver}}</driverClassName>
            {% for property_name,property_value in database.shared_db.pool_options.items() %}
            <{{property_name}}>{{property_value}}</{{property_name}}>
            {% endfor %}
            <jmxEnabled>{{database.shared_db.jmx_enable}}</jmxEnabled>
        </configuration>
    </definition>
</datasource>

<datasource>
    <name>WSO2_IDENTITY_DB</name>
    <description>Shared database for identity data</description>
    <jndiConfig>
        <name>jdbc/WSO2IdentityDB</name>
    </jndiConfig>
    <definition type="RDBMS">
        <configuration>
            <url>{{database.identity_db.url}}</url>
            <username>{{database.identity_db.username}}</username>
            <password>{{database.identity_db.password}}</password>
            <driverClassName>{{database.identity_db.driver}}</driverClassName>
            {% for property_name,property_value in database.identity_db.pool_options.items() %}
            <{{property_name}}>{{property_value}}</{{property_name}}>
            {% endfor %}
        </configuration>
    </definition>
</datasource>
</datasources>

Steps to Reproduce

N/A

Version

IS 7.0.0

Environment Details (with versions)

No response