Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topo background issue #288

Open
TatsuJohnson opened this issue Apr 5, 2021 · 6 comments
Open

Topo background issue #288

TatsuJohnson opened this issue Apr 5, 2021 · 6 comments

Comments

@TatsuJohnson
Copy link

The background element for wvu-bg-topo-light and wvu-bg-topo-dark uses a different version of the topographic pattern than we use in our official branding. This can be seen at https://www.wvu.edu/inclusive-campus/resources vs the background on https://campusrecreation.wvu.edu/home.

Screen Shot 2021-04-05 at 12 31 49 PM

@adamjohnson
Copy link
Contributor

static.wvu.edu has a list of topo backgrounds in the manifest.json file.

@TatsuJohnson
Copy link
Author

Looks like it might just be the svg version.

@zeroedin
Copy link
Contributor

zeroedin commented Apr 5, 2021

Yes, because the .png is large in size 375kb vs svg 93kb. @adamglenn and I created the .svgs to reduce as much weight as possible for the homepage and I made sure to make those available on static. And they most likely those svgs should be incorporated back into the design system.

@TatsuJohnson
Copy link
Author

It's just that the svgs are different in design than the pngs.

@zeroedin
Copy link
Contributor

zeroedin commented Apr 5, 2021

It was actually created from the same source. I believe @adamglenn cropped it differently when he created the SVG.

@TatsuJohnson
Copy link
Author

If you look at the source, I don't think the topo lines ever touch, or have sharp edges like that. Somehow the svg got simplified and messed up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants