Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change class for the Photo Gallery component to be more specific #289

Open
adamjohnson opened this issue Apr 7, 2021 · 0 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@adamjohnson
Copy link
Contributor

adamjohnson commented Apr 7, 2021

Steps to reproduce the issue

Right now, the Photo Gallery component uses a pretty generic class of .photos to trigger the Magnific Popup gallery.

Results

The .photos class is very generic and can lead to confusion if someone were using this component but wanted to use it in a different way (see Reed Innovation's Events page).

Expected results

If we changed the class to something like .js-wvu-lightbox-gallery, I don't think we'd see confusion or style/script conflicts.

How to fix

Since many people use the photo gallery component in the wild, does it make sense to make a new v2 partial or can we just change the .photos class to .js-wvu-lightbox-gallery and be done?

My initial thought is that we could change the class—but let me know if I'm incorrect here.

@adamjohnson adamjohnson added the enhancement New feature or request label Apr 7, 2021
@adamjohnson adamjohnson self-assigned this Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant