Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ugly borders on the mobile + buttons in main navigation #293

Open
adamjohnson opened this issue May 28, 2021 · 1 comment
Open

Ugly borders on the mobile + buttons in main navigation #293

adamjohnson opened this issue May 28, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@adamjohnson
Copy link
Contributor

Steps to reproduce the issue

  1. Go to a site that uses the Design System + the default dropdown navigation (eg: Academic Integrity)
  2. View the site on a small viewport.
  3. Expand the mobile navigation menu.

Results

The + buttons for the dropdowns have a browser default, ugly border around them.

Expected results

Borders should look more rad.

After looking into this, the fix is simple. To fix, include these two tint and shade functions to make the borders look awesome again. _wvu-nav-dropdowns.scss already uses these two functions.

Here's the step by step:

  1. Create a new file in: scss/mixins called _wvu-tint-shade.scss.
  2. Go to the CSS Tricks URL above, copy the two functions, paste them into the file you just made.
  3. @import 'mixins/wvu-tint-shade'; on line 60 of styles.scss.
  4. Issue fixed, submit pull request. 🎉
@adamjohnson adamjohnson added enhancement New feature or request good first issue Good for newcomers labels May 28, 2021
@adamjohnson adamjohnson self-assigned this May 28, 2021
@adamjohnson
Copy link
Contributor Author

adamjohnson commented May 28, 2021

Interestingly enough, this also adds borders & a background color change on hover to the main navigation items on non-mobile screens too:

Borders on main navigation items on desktop

I'm a fan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant