Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export IFC GUID as mesh name (instead of IfcName + EntityLabel) #11

Open
Hafplo opened this issue Nov 16, 2020 · 3 comments
Open

Export IFC GUID as mesh name (instead of IfcName + EntityLabel) #11

Hafplo opened this issue Nov 16, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@Hafplo
Copy link

Hafplo commented Nov 16, 2020

Currently the GLTF file creates meshes and populates the 'name' property with the IfcName of the element + the IfcEntityLabel of the element (the "row number" in the IFC file)

since names don't follow any convention, I believe it is more robust to use the IfcGUID instead.
IfcGUID is unique per element, and doesn't change in cases of minor changes to the IFC file (i.e. authoring or editing), while the name can change (i.e. changing the convention, translating) and entity labels can also change.

Also IfcGUID is mandatory for all elements and objects.

@CBenghi
Copy link
Member

CBenghi commented Dec 4, 2020

Hello @Hafplo,

thanks for the feedback, are you referring to the nodes ?
Nodes currently have this type of name:

{
  "matrix": [
	0.0, 	-1.0, 	0.0,  	0.0, 	1.0, 	0.0, 	0.0, 	0.0, 	0.0, 	0.0, 	1.0, 	0.0, 	2.538, 	-0.417, 	0.0, 	1.0   ],
  "mesh": 4,
  "name": "Basic Wall:Interior - Partition (92mm Stud):138584 #4131"
},

They point to a mesh, and have a name and a matrix.

You're suggesting to have that changed to "name": "2O2Fr$t4X7Zf8NOew3FNld"?

@CBenghi CBenghi self-assigned this Dec 4, 2020
@CBenghi CBenghi added enhancement New feature or request question Further information is requested labels Dec 4, 2020
@Hafplo
Copy link
Author

Hafplo commented Dec 15, 2020

@CBenghi exactly.
GUID should be the identifier for every element. It is more stable and robust.

@Hafplo
Copy link
Author

Hafplo commented Sep 13, 2021

@CBenghi any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants