Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process ZMQ notifications about pending moves #43

Open
domob1812 opened this issue May 2, 2019 · 3 comments
Open

Process ZMQ notifications about pending moves #43

domob1812 opened this issue May 2, 2019 · 3 comments
Assignees
Milestone

Comments

@domob1812
Copy link
Collaborator

With xaya/xaya#91 (also backported to 1.2), Xaya Core now supports publishing ZMQ notifications about pending moves. We should check whether that is enabled in getzmqnotifications and if it is, support processing them and forwarding to game-specific callbacks.

@domob1812 domob1812 added this to the 0.1 milestone May 2, 2019
@domob1812 domob1812 self-assigned this May 2, 2019
@domob1812
Copy link
Collaborator Author

We will add a new interface PendingMoveProcessor, which has two methods Clear and AddPendingMove. The first one will be called whenever a new block comes in, and then moves that are still pending as well as pending moves that come in over time will be added with the second method.

Concrete GSP implementations can then (if they want to) pass an instance of PendingMoveProcessor to Game, and have it process moves based on their needs.

@domob1812
Copy link
Collaborator Author

The unit tests for processing of pending moves in ChainToChannelFeeder seem to run into this issue: cinemast/libjson-rpc-cpp#277

@domob1812
Copy link
Collaborator Author

With #84 done, all that remains is actually using the pending moves exposed by a GSP in a channel daemon. This is work in progress, but currently blocked on the issue mentioned in the previous comment. It is not very important, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant