Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar nav on small desktop screen sizes is too close to the bottom #286

Closed
Rigidity opened this issue Jan 18, 2025 · 4 comments · Fixed by #311
Closed

Sidebar nav on small desktop screen sizes is too close to the bottom #286

Rigidity opened this issue Jan 18, 2025 · 4 comments · Fixed by #311
Labels
bug Something isn't working ui Display issue

Comments

@Rigidity
Copy link
Collaborator

No description provided.

@Rigidity Rigidity added bug Something isn't working ui Display issue labels Jan 18, 2025
@dkackman
Copy link
Contributor

can you post a screen shot? what im seeing is that it matches the mobile layout, hiding the sidebar, switching to the hamburger. there is a minimum height at which that start to get unusable but seems pretty small.

Image

@Rigidity
Copy link
Collaborator Author

Image

@Rigidity
Copy link
Collaborator Author

It works fine, but there's inconsistent/lacking padding on the bottom. I tried manually increasing it but then it's too much on mobile. I think it's because it's using the mobile insets which are 0 on Desktop and like 16 on iOS.

@Rigidity
Copy link
Collaborator Author

This isn't a big deal and I don't forsee anyone using the app like this, just an edge case.

dkackman added a commit to dkackman/sage that referenced this issue Jan 25, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui Display issue
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants