Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: move EnumAttribute and helpers out of core.py #3753

Open
superlopuh opened this issue Jan 15, 2025 · 3 comments
Open

API: move EnumAttribute and helpers out of core.py #3753

superlopuh opened this issue Jan 15, 2025 · 3 comments
Labels
API Related to changes regarding API of constructs good first issue Good for newcomers

Comments

@superlopuh
Copy link
Member

These aren't actually core data structures, so don't belong in this file that is trying to present a minimal API layer for core data structure manipulation.

CC @math-fehr
@superlopuh superlopuh added API Related to changes regarding API of constructs good first issue Good for newcomers labels Jan 15, 2025
@compor
Copy link
Collaborator

compor commented Jan 30, 2025

What constitutes "core"? Is it just the basic components to represent the IR?

@superlopuh
Copy link
Member Author

My current take is that it's the minimal API surface to implement the IR.

@compor
Copy link
Collaborator

compor commented Jan 30, 2025

Let's document this once we have readthedocs doc in a sort of project structure walkthrough or similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Related to changes regarding API of constructs good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@superlopuh @compor