Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disqus comment widget does not change theme properly #412

Open
shaform opened this issue Jan 7, 2025 · 0 comments · May be fixed by #413
Open

Disqus comment widget does not change theme properly #412

shaform opened this issue Jan 7, 2025 · 0 comments · May be fixed by #413

Comments

@shaform
Copy link
Collaborator

shaform commented Jan 7, 2025

Supposedly, Disqus supports dark and light themes: https://www.jamesrmeyer.com/otherstuff/dark-mode-demo/dark-mode-demo-disqus

However, the Disqus widget is not behaving as expected with hugo-theme-jane. In particular, when dark theme is enabled, the texts would change colors, but the background is still white, which makes it difficult to read.

It is unclear why this is the case though. It seems Disqus is utilizing a transparent iframe which should inherit the background color of its parent. But this does not work properly with hugo-theme-jane for unknown reasons.

In particular, I observe the following strange behaviors:

  1. If we switch to dark theme and then load Disqus, the texts would become white but the background would stay white.
  2. If we switch to light theme and then load Disqus, and then switch to dark theme again, the texts would be dark and the background would also be dark.

For both cases, the texts are difficult to read.

Note: the second behavior seems to only happen on Chrome. With Firefox, only 1 would happen.

@shaform shaform linked a pull request Jan 7, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant