From b799e66c61aae599cbab2e9f994455eb26708483 Mon Sep 17 00:00:00 2001
From: Andrew Plaza <github@andrewplaza.dev>
Date: Fri, 31 Jan 2025 15:52:43 -0500
Subject: [PATCH] remove redundant clippy checks from CI

---
 .github/workflows/lint-ffi-bindings.yaml  | 41 -----------------------
 .github/workflows/lint-node-bindings.yaml | 24 -------------
 .github/workflows/lint-workspace.yaml     |  2 ++
 3 files changed, 2 insertions(+), 65 deletions(-)
 delete mode 100644 .github/workflows/lint-ffi-bindings.yaml

diff --git a/.github/workflows/lint-ffi-bindings.yaml b/.github/workflows/lint-ffi-bindings.yaml
deleted file mode 100644
index bf4212009..000000000
--- a/.github/workflows/lint-ffi-bindings.yaml
+++ /dev/null
@@ -1,41 +0,0 @@
-name: Lint FFI Bindings
-on:
-  push:
-    branches:
-      - main
-  pull_request:
-    paths:
-      - "bindings_ffi/**"
-      - ".github/workflows/lint-ffi-bindings.yaml"
-      - "rustfmt.toml"
-env:
-  CARGO_TERM_COLOR: always
-  CARGO_INCREMENTAL: 0
-  RUSTFLAGS: -D warnings --cfg tracing_unstable
-  CARGO_PROFILE_TEST_DEBUG: 0
-jobs:
-  lint:
-    name: Lint
-    runs-on: warp-ubuntu-latest-x64-16x
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-      - name: Update rust toolchains
-        run: rustup update
-      - uses: taiki-e/install-action@v2
-        with:
-          tool: clippy-sarif,sarif-fmt
-      - name: Cache
-        uses: Swatinem/rust-cache@v2
-        with:
-          workspaces: |
-            .
-            bindings_ffi
-      - name: Run clippy and fail on warnings
-        run: cargo clippy --locked --manifest-path bindings_ffi/Cargo.toml --all-features --all-targets --no-deps --message-format=json | clippy-sarif | tee results.sarif | sarif-fmt
-      - name: Upload SARIF file
-        uses: github/codeql-action/upload-sarif@v2
-        with:
-          sarif_file: results.sarif
-      - name: Run format check
-        run: cargo fmt --manifest-path bindings_ffi/Cargo.toml --check
diff --git a/.github/workflows/lint-node-bindings.yaml b/.github/workflows/lint-node-bindings.yaml
index 1eb5d9c45..220aeade8 100644
--- a/.github/workflows/lint-node-bindings.yaml
+++ b/.github/workflows/lint-node-bindings.yaml
@@ -5,11 +5,6 @@ on:
       - "bindings_node/**"
       - ".github/workflows/lint-node-bindings.yaml"
       - "rustfmt.toml"
-env:
-  CARGO_TERM_COLOR: always
-  CARGO_INCREMENTAL: 0
-  RUSTFLAGS: -D warnings --cfg tracing_unstable
-  CARGO_PROFILE_TEST_DEBUG: 0
 jobs:
   lint:
     name: Lint
@@ -17,25 +12,6 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
-      - name: Update rust toolchains
-        run: rustup update
-      - uses: taiki-e/install-action@v2
-        with:
-          tool: clippy-sarif,sarif-fmt
-      - name: Cache
-        uses: Swatinem/rust-cache@v2
-        with:
-          workspaces: |
-            .
-            bindings_node
-      - name: Run clippy and fail on warnings
-        run: cargo clippy --locked --manifest-path bindings_node/Cargo.toml --all-features --all-targets --no-deps --message-format=json | clippy-sarif | tee results.sarif | sarif-fmt
-      - name: Upload SARIF file
-        uses: github/codeql-action/upload-sarif@v2
-        with:
-          sarif_file: results.sarif
-      - name: Run format check
-        run: cargo fmt --manifest-path bindings_node/Cargo.toml --check
       - name: Setup node
         uses: actions/setup-node@v4
         with:
diff --git a/.github/workflows/lint-workspace.yaml b/.github/workflows/lint-workspace.yaml
index 1c5e8365d..6f6641106 100644
--- a/.github/workflows/lint-workspace.yaml
+++ b/.github/workflows/lint-workspace.yaml
@@ -15,6 +15,8 @@ on:
       - "xmtp_proto/**"
       - "xmtp_v2/**"
       - "xmtp_debug/**"
+      - "bindings_node/**"
+      - "bindings_ffi/**"
       - "Cargo.toml"
       - "Cargo.lock"
       - "rust-toolchain"