From a9e96274c4217739a02e4b94a5fd64683a4a8cd2 Mon Sep 17 00:00:00 2001
From: Ry Racherbaumer <ry@xmtp.com>
Date: Sat, 1 Feb 2025 13:41:07 -0600
Subject: [PATCH 1/2] Prepare node bindings for release

---
 bindings_node/CHANGELOG.md | 4 ++++
 bindings_node/package.json | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/bindings_node/CHANGELOG.md b/bindings_node/CHANGELOG.md
index f146b33dd..247b0ac10 100644
--- a/bindings_node/CHANGELOG.md
+++ b/bindings_node/CHANGELOG.md
@@ -1,5 +1,9 @@
 # @xmtp/node-bindings
 
+## 0.0.36
+
+- Fixed DM group metadata validation
+
 ## 0.0.35
 
 - Updated `createDm` to return an existing DM group, if it exists
diff --git a/bindings_node/package.json b/bindings_node/package.json
index afbd45bce..8c8f418e1 100644
--- a/bindings_node/package.json
+++ b/bindings_node/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@xmtp/node-bindings",
-  "version": "0.0.35",
+  "version": "0.0.36",
   "repository": {
     "type": "git",
     "url": "git+https://git@github.com/xmtp/libxmtp.git",

From 369b96dd746cc081ec231028abe8bb54d6a5f7cf Mon Sep 17 00:00:00 2001
From: Ry Racherbaumer <ry@xmtp.com>
Date: Sat, 1 Feb 2025 13:49:09 -0600
Subject: [PATCH 2/2] Update tests

---
 bindings_node/test/Conversations.test.ts | 32 +++++++++++++++++++++++-
 bindings_node/vitest.config.mts          |  1 +
 2 files changed, 32 insertions(+), 1 deletion(-)

diff --git a/bindings_node/test/Conversations.test.ts b/bindings_node/test/Conversations.test.ts
index 0c8ed0292..fa388ca04 100644
--- a/bindings_node/test/Conversations.test.ts
+++ b/bindings_node/test/Conversations.test.ts
@@ -488,11 +488,32 @@ describe('Conversations', () => {
     await client1.conversations().createGroup([user3.account.address])
     await client1.conversations().createDm(user4.account.address)
 
-    let messages: Message[] = []
+    const messages: Message[] = []
     const stream = client1.conversations().streamAllMessages((err, message) => {
       messages.push(message!)
     })
 
+    const messages2: Message[] = []
+    const stream2 = client2
+      .conversations()
+      .streamAllMessages((err, message) => {
+        messages2.push(message!)
+      })
+
+    const messages3: Message[] = []
+    const stream3 = client3
+      .conversations()
+      .streamAllMessages((err, message) => {
+        messages3.push(message!)
+      })
+
+    const messages4: Message[] = []
+    const stream4 = client4
+      .conversations()
+      .streamAllMessages((err, message) => {
+        messages4.push(message!)
+      })
+
     const groups2 = client2.conversations()
     await groups2.sync()
     const groupsList2 = groups2.list()
@@ -512,8 +533,17 @@ describe('Conversations', () => {
     await sleep()
 
     stream.end()
+    stream2.end()
+    stream3.end()
+    stream4.end()
     expect(messages.length).toBe(3)
     expect(messages.map((m) => m.id)).toEqual([message1, message2, message3])
+    expect(messages2.length).toBe(1)
+    expect(messages2.map((m) => m.id)).toEqual([message1])
+    expect(messages3.length).toBe(1)
+    expect(messages3.map((m) => m.id)).toEqual([message2])
+    expect(messages4.length).toBe(1)
+    expect(messages4.map((m) => m.id)).toEqual([message3])
   })
 
   it('should only stream group chat messages', async () => {
diff --git a/bindings_node/vitest.config.mts b/bindings_node/vitest.config.mts
index 0df1b1b53..2f7b0ccb7 100644
--- a/bindings_node/vitest.config.mts
+++ b/bindings_node/vitest.config.mts
@@ -11,6 +11,7 @@ const viteConfig = defineConfig({
 const vitestConfig = defineVitestConfig({
   test: {
     globalSetup: ['./vitest.setup.mts'],
+    testTimeout: 30000,
   },
 })