Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

建议增加xgrammar结构化输出支持 #2620

Open
ZanePoe opened this issue Dec 2, 2024 · 11 comments
Open

建议增加xgrammar结构化输出支持 #2620

ZanePoe opened this issue Dec 2, 2024 · 11 comments
Milestone

Comments

@ZanePoe
Copy link

ZanePoe commented Dec 2, 2024

Feature request / 功能建议

如题

Motivation / 动机

已知贵团队已经在做outlines结构化输出支持,但最新的国内团队的xgrammar技术相比于outlines有明显的优势,并且sglang这种高速推理引擎已经得到支持,并且vllm团队也积极响应准备支持xgrammar。
bd82fb84450153899752da0bb1814d9
xgrammar相比于outlines优势很是挺明显的:
4ac00241aa9bf526283b9a693623572

Your contribution / 您的贡献

https://github.com/mlc-ai/xgrammar

@ZanePoe ZanePoe added the feature label Dec 2, 2024
@XprobeBot XprobeBot added this to the v1.x milestone Dec 2, 2024
@qinxuye
Copy link
Contributor

qinxuye commented Dec 4, 2024

@wxiwnd 可以看看,在 outlines 之后可以支持这个。

@wxiwnd
Copy link
Contributor

wxiwnd commented Dec 4, 2024

好的。如果 vllm 后续支持的话,大概只需要改一下 backend 为 xgrammar 应该就行了。
其他的 engine 应该需要单独适配

@ZanePoe
Copy link
Author

ZanePoe commented Dec 11, 2024

同时结构化输出希望能够兼容openai,希望openai接口能支持response_format参数进行json结构化输出。vllm / sglang 原生openai接口均已支持该参数

@qinxuye
Copy link
Contributor

qinxuye commented Dec 11, 2024

#2636 有反馈用 openai 接口会有问题。

Copy link

This issue is stale because it has been open for 7 days with no activity.

@github-actions github-actions bot added the stale label Dec 18, 2024
@qinxuye qinxuye removed the stale label Dec 23, 2024
@qinxuye
Copy link
Contributor

qinxuye commented Dec 23, 2024

@Jun-Howie guided json is introduced in #2391 , and openai-compatible in #2673 .

It should not be hard to introduce xgrammar as backend for vllm.

Copy link

This issue is stale because it has been open for 7 days with no activity.

@github-actions github-actions bot added the stale label Dec 30, 2024
Copy link

github-actions bot commented Jan 4, 2025

This issue was closed because it has been inactive for 5 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 4, 2025
@qinxuye qinxuye reopened this Jan 5, 2025
@qinxuye qinxuye removed the stale label Jan 5, 2025
Copy link

This issue is stale because it has been open for 7 days with no activity.

@github-actions github-actions bot added the stale label Jan 12, 2025
@qinxuye qinxuye removed the stale label Jan 18, 2025
Copy link

This issue is stale because it has been open for 7 days with no activity.

@github-actions github-actions bot added the stale label Jan 25, 2025
@qinxuye qinxuye removed the stale label Jan 27, 2025
Copy link

github-actions bot commented Feb 3, 2025

This issue is stale because it has been open for 7 days with no activity.

@github-actions github-actions bot added the stale label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants