Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linkifying includes trailing '.' #1135

Closed
rightparen opened this issue Nov 29, 2017 · 3 comments
Closed

Linkifying includes trailing '.' #1135

rightparen opened this issue Nov 29, 2017 · 3 comments

Comments

@rightparen
Copy link

Details

Linkifying includes a trailing '.' as part of a URL's path. This can cause problems in the common scenario of a terminal program displaying output that ends a sentence with a URL.

  • Browser and browser version: Google Chrome Version 62.0.3202.94 (Official Build) (64-bit)
  • OS version: macOS Sierra Version 10.12.6
  • xterm.js version: v2.9.2 and current master

Steps to reproduce

  1. Run the demo.

  2. Enter the command:
    echo "Please see https://github.com/xtermjs/xterm.js/issues."

  3. Click the echoed link.

Expected: Link references https://github.com/xtermjs/xterm.js/issues
Actual: Link references https://github.com/xtermjs/xterm.js/issues., which results in 404 Not Found.

@rightparen
Copy link
Author

To be fair, the current behavior is technically correct, since '.' is a legal URL path character. It's just less usable this way.

@egmontkob
Copy link

(See also #583.)

@Tyriar
Copy link
Member

Tyriar commented Dec 11, 2017

Duplicate #583

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants