-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lets make the DOM renderer great again #1896
Comments
None of them support blink, too much work for something that is rarely used and an accessibility nightmare. |
@Tyriar Tbh Im not aware of single terminal program in the last 20ys that uses blinking for some important feature. I think Turbo Pascal under DOS had some blinking animation after compiling or when an error was found, cannot remember exactly. 😄 |
The flash/blink attribute was an original DIGITAL terminal favorite of mine:
I agree with @Tyriar for the reasons listed, but having those available for ANSI art, MUD clients, whatever, are often left wanting in a terminal emulator. Is there a middle-ground? Could this be accomplished as add-on goal with its extended CSI handling? |
Hmm maybe we should hide it behind some option? I see a reason to be able to completely disable it, blinking often annoys ppl. |
Custom CSI handler + #1852 would probably make it possible. |
Most of this is done now thanks for community contributions 🎉, let's close this off and create issues for any remaining lack of functionality. Initially the DOM renderer was just the fallback but it will likely be the default in the future and users will be able to opt in to using GPU acceleration with the webgl renderer, so it should be just as solid as the others 💪 |
The DOM renderer needs some love. It kinda fell behind and still misses some flags like INVISIBLE, BLINK and DIM. Furthermore we might want to investigate if we can speedup things by less
<span>
ning.The text was updated successfully, but these errors were encountered: