Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide toggle buttons on demo for enabling/disabling addons #2407

Closed
Tyriar opened this issue Sep 9, 2019 · 2 comments · Fixed by #2518
Closed

Provide toggle buttons on demo for enabling/disabling addons #2407

Tyriar opened this issue Sep 9, 2019 · 2 comments · Fixed by #2518
Assignees
Labels
area/demo type/enhancement Features or improvements to existing features
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 9, 2019

It would be nice to have a standard way to disable and enable all the addons just like with settings. This would be particularly useful for WebGL and Ligatures which should probably remain disabled by default.

@Tyriar Tyriar added type/enhancement Features or improvements to existing features help wanted area/demo labels Sep 9, 2019
@glneto
Copy link
Contributor

glneto commented Oct 17, 2019

You mean one option to Enable/Disable all or one option for each addon? Also, should they be enabled or disabled by default?

@Tyriar
Copy link
Member Author

Tyriar commented Oct 17, 2019

@glneto individual checkboxes for each addon in a new section. Right now there is a single button for webgl but if all the addons had checkboxes that would be great.

Note that webgl currently doesn't implement dispose properly so it won't work for that #2254, but unchecking web links for example should stop linkifying new web links.

For enabled by default, have their initial state being whatever the demo does right now (webgl is disabled, web links are enabled, etc.), for the attach addon have a button but mark it as disabled since I think unchecking would break the demo.

Tyriar added a commit to Tyriar/xterm.js that referenced this issue Oct 27, 2019
@Tyriar Tyriar added this to the 4.3.0 milestone Oct 27, 2019
@Tyriar Tyriar self-assigned this Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/demo type/enhancement Features or improvements to existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants