Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overview ruler annotations don't get cleared when search term is cleared #3737

Closed
meganrogge opened this issue Apr 19, 2022 · 2 comments · Fixed by #3738
Closed

overview ruler annotations don't get cleared when search term is cleared #3737

meganrogge opened this issue Apr 19, 2022 · 2 comments · Fixed by #3738
Assignees
Milestone

Comments

@meganrogge
Copy link
Member

meganrogge commented Apr 19, 2022

Originally reported microsoft/vscode#147659 and can be repro'd in the demo

Steps to reproduce

  1. search for a single letter with highlight all matches enabled
  2. remove the search term
  3. 🐛 the decorations are cleared, but their corresponding overview ruler decorations remain
@meganrogge meganrogge self-assigned this Apr 19, 2022
@meganrogge meganrogge added this to the 4.19.0 milestone Apr 19, 2022
@meganrogge
Copy link
Member Author

The decorations get disposed of properly, but don't clear until a refresh of overview ruler happens -- for example, the buffer changes

@meganrogge
Copy link
Member Author

meganrogge commented Apr 19, 2022

In order to avoid refreshing every time a decoration is deleted, I'd rather do this once when clearDecorations happens. Currently, there isn't a way for the addon to communicate with overviewRuler though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant