-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could not linkify the URL with super-long TLDs. #601
Comments
PRs welcome, should be an easy fix 👍 |
@Tyriar Would happy to contribute, for me 256 ought to be enough for anybody? ;) |
@jens1o the concern with working more on the web link matcher as is, is that it will eventually be replaced by something much smarter that can understand things like when brackets () are within or outside of a URL, see #583 And that one's a bit more work 😛 as it's replacing all the regex logic with a parser that will probably work by finding the start of a link and then move forward until the end is found. |
Oh, sorry. I think I won't meet your expectations... Let's hope there will be some nice contributor with some good skills :D |
No worries 😄 |
Merging into #583 |
Currently Linkifier implimentation could not linkify the URL with super-long TLDs.
Linkifier assume the TLD lenght in 2 - 6 chars in the here,
https://github.com/sourcelair/xterm.js/blob/master/src/Linkifier.ts#L14
But, some new gTLDs have over 6 chars. (ex: .enterprises, .foundation, and so on).
Needs to update
tldClause
to support these super-long TLD names.Details
Steps to reproduce
The text was updated successfully, but these errors were encountered: