Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling & reanabling mod causes graphical artifacts #3

Open
DoctorVanGogh opened this issue Mar 29, 2021 · 3 comments
Open

Disabling & reanabling mod causes graphical artifacts #3

DoctorVanGogh opened this issue Mar 29, 2021 · 3 comments

Comments

@DoctorVanGogh
Copy link

Did some tests with 0.5.1 (due to #1 & #2) and noticed that things get utterly wonky if you fire up a map with VolumetricShading enabled, then disable the mod, load the map again and even worse if you then reenable the VolumetricShading and load the map a third time:

Reproduction steps:

  1. Start game fresh (*)
  2. Enable VolumetricShading
  3. Load a map
    (Maybe 2b?) Force rain to fall /weather setprecip 1
  4. Close map
  5. Disable VolumetricShading
  6. Load map - some artifacts appear:
    https://www.youtube.com/watch?v=OuaujTmJVEo
    (note the flickering on the hill face ahead and house wall behind you)
  7. Close map
  8. Reenable VolumetricShading
  9. Load map - horrible artifacts everywhere:
    https://www.youtube.com/watch?v=A3YGQTljPV8

I'm not entirely convinced this is an issue caused by VolumetricShading - might as well be some wonkyness in shader asset loading by the engine (note the issues cropping up even with vanilla shaders if custom assets were used previously). Leaving it up to you to potentially push this upstream.


(*) Switching the "fullscreen" option from settings will make all those artifacts disappear (presumably since this disposes lots of internal buffers in the graphics pipeline and things get loaded up clean again).

@DoctorVanGogh DoctorVanGogh changed the title Disabling & reanabling mod causes graphical artefacts Disabling & reanabling mod causes graphical artifacts Mar 29, 2021
@xxmicloxx
Copy link
Owner

xxmicloxx commented Mar 29, 2021

The flickering you see seems to be Z-Fighting in the depth buffer. The artifacts in the second video are probably caused by some shader not compiling correctly, which causes the "stuck" shadow overlay. I'm not quite sure what causes this, but a switch from/to fullscreen recreates the frame buffers so this could be a potential fix. Can you try if resizing the vintage story window also works, or if you need to use the fullscreen option in the settings?

PS: It would also be very nice to know which GPU you are using exactly. It allows me to look up any OpenGL limitations that particular GPU might have.

@DoctorVanGogh
Copy link
Author

It would also be very nice to know which GPU you are using exactly.

It's an AMD Vega 64 running with drivers from Jan of this year.

@xxmicloxx
Copy link
Owner

xxmicloxx commented Mar 29, 2021

(commented this on the wrong issue, see #2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants