Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new-log-viewer: "dd" timestamp format specifier doesn't result in a zero-padded date. #87

Closed
kirkrodrigues opened this issue Oct 2, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@kirkrodrigues
Copy link
Member

Bug

When the user specifies the timestamp format as %d{yyyy-MM-dd HH:mm:ss.SSS}, a timestamp like "2024-Oct-01 00:00:00.000" will get rendered as "2024-Oct-1 00:00:00.000", where the date is not zero-padded.

This appears to be a simple typo here where we should be converting "dd" to "DD".

yscope-log-viewer version

b6b63ea

Environment

Firefox 130.0.1.

Reproduction steps

  • Open a JSONL file that has a timestamp field with the format "2024-Oct-01 00:00:00.000" in the new log viewer.
  • Observe that the rendered date is not zero-padded.
@kirkrodrigues kirkrodrigues added the bug Something isn't working label Oct 2, 2024
@kirkrodrigues kirkrodrigues changed the title new-log-viewer: "dd" timestamp format specifier doesn't result in a zero-padded day. new-log-viewer: "dd" timestamp format specifier doesn't result in a zero-padded date. Oct 2, 2024
@junhaoliao
Copy link
Member

This issue no longer exists since the introduction of the YScope formatter in #123 , right? Can we close this?

@kirkrodrigues
Copy link
Member Author

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants