Unnecessary actions in angle caclulation

[sergeyshashmurin]

Hello! Your repo is very helpful for me!
But I find one unnecessary action in your code. Your func calcVectorAngle is unnecessary
Your code in line_boundary_check.py:

def calcVectorAngle( point1, point2, point3, point4 ):
  u = np.array(line_vectorize(point1, point2))
  v = np.array(line_vectorize(point3, point4))
  i = np.inner(u, v)
  n = LA.norm(u) * LA.norm(v)
  c = i / n
  a = np.rad2deg(np.arccos(np.clip(c, -1.0, 1.0)))
  if u[0]*v[1]-u[1]*v[0]<0:
    return a
  else:
    return 360-a

Your code in test-line-cross-area-intrusion.py:

    if intersect == True:
        angle = calcVectorAngle(traj_p0, traj_p1, bLine_p0, bLine_p1)   # Calculate angle between trajectory and boundary line
        if angle<180:
            boundary_line.count1 += 1
        else:
            boundary_line.count2 += 1

What I suggest:

def calc_orientation(point1, point2, point3, point4):
    u = np.array(line_vectorize(point1, point2))
    v = np.array(line_vectorize(point3, point4))
    return u[0] * v[1] - u[1] * v[0] < 0

    if intersect == True:
        if calc_orientation(traj_p0, traj_p1, bLine_p0, bLine_p1):
            boundary_line.count1 += 1
        else:
            boundary_line.count2 += 1