Skip to content
This repository has been archived by the owner on Nov 22, 2021. It is now read-only.

Add complete interfaces for everything #55

Closed
banteg opened this issue Oct 21, 2020 · 1 comment · May be fixed by #59
Closed

Add complete interfaces for everything #55

banteg opened this issue Oct 21, 2020 · 1 comment · May be fixed by #59
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed p3 Fix if time

Comments

@banteg
Copy link
Member

banteg commented Oct 21, 2020

Currently we use abridged interfaces which doesn't include functions besides those used in the contract.

Full interfaces might be useful for tests and interactive sessions, and they don't affect the resulting compiler output size, so no real downsides.
@milkyklim milkyklim added enhancement New feature or request help wanted Extra attention is needed labels Oct 26, 2020
@tansawit tansawit mentioned this issue Oct 29, 2020
Open
@saltyfacu saltyfacu added p3 Fix if time good first issue Good for newcomers labels Feb 4, 2021
@saltyfacu
Copy link

Repository is superseded by yearn-vaults

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed p3 Fix if time
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] - chore: add complete interfaces tansawit/yearn-protocol
3 participants
@saltyfacu @banteg @milkyklim