Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for extending TTR #250

Open
SamMousa opened this issue Jul 10, 2018 · 1 comment
Open

Add support for extending TTR #250

SamMousa opened this issue Jul 10, 2018 · 1 comment
Labels
type:enhancement Enhancement

Comments

@SamMousa
Copy link
Contributor

TTR is a mechanic to release crashed / stalled jobs back into the queue.
Sometimes jobs are slow but not stalled.
Consider the DownloadJob from the docs; I could easily make this job exceed its TTR by throttling the connection at the server.
However since the process is alive and actually doing what it is supposed to do (assuming it is still actually receiving more than 0 b/s) we might want to tell the queue that we're still busy and it shouldn't release our job to someone else just yet.

Beanstalk protocol uses touch for this, and this shouldn't be hard to implement for other drivers.
The database driver currently doesn't do TTR at all (#249). When it does, all we need to do to extend the time is update the reserved_at field.
For other drivers I'm not sure how to implement this exactly, but I don't think it'll be hard.

@samdark samdark added the type:enhancement Enhancement label Jul 10, 2018
@githubjeka
Copy link

Rel #249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Enhancement
Projects
None yet
Development

No branches or pull requests

3 participants