Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to ignore regex pattern warning #242

Open
sirmspencer opened this issue Jun 15, 2023 · 6 comments
Open

Option to ignore regex pattern warning #242

sirmspencer opened this issue Jun 15, 2023 · 6 comments

Comments

@sirmspencer
Copy link

In our set up, I generate a .clj file to match the generated edn file, and they stay in the same migration directory.

image

We don't need to see a warning for every .clj file that won't match the regex.

@yogthos
Copy link
Owner

yogthos commented Jun 15, 2023

Perhaps we could add an optional config flag for allowed extensions and then pass it to migratus.migrations/warn-on-invalid-migration. Should be pretty straight forward, let me know if you'd be ok to do a pr for that.

@sirmspencer
Copy link
Author

I can give it a try.

@sirmspencer
Copy link
Author

@yogthos Can you add a development guide in the readme or a CONTRIBUTE.md?

@yogthos
Copy link
Owner

yogthos commented Jun 17, 2023

What would you like to see there. There's not much to it, you just check out and run with either deps or lein, and just do a PR once the tests are passing.

@sirmspencer
Copy link
Author

Good question. You mention tests, which is something I would expect, but not sure what test suite you are using, as an example. How could I dev / test from within my project? Lein checkouts? I know just enough to look for things, but a quick guide would make that easier.

Do you have a slack channel somewhere? This ticket might be redundant with a larger plan I am thinking of. I have permission to work on this on company time so this would all be something I would work on once we talk it out.

@yogthos
Copy link
Owner

yogthos commented Jun 18, 2023

Oh yeah, I'm on Clojurians slack https://clojurians.net with the same id, just ping me on there and we can chat through it. If you want to test a new version locally as a library, the easiest would be to bump up the version in project.clj and run lein install on your machine. This will install the version to your local repo, and you can reference it from your project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants