Create unit tests

[supasate]

No description provided.

[p16i]

Since most of logics for youpin-bot are inside youpin.js. So I think we can start from there.

[supasate]

Just read youpin.js. The function is so scarily long and hard to do unit test. Is is possible to break it into smaller functions? @tvirot

[tvirot]

Lol, yup :) I think we can have one function to handle each state and turn
the long if-else clauses into a switch-case statement calling a proper
function based on the current state.

On Sunday, October 2, 2016, Supasate Choochaisri [email protected]
wrote:

Just read youpin.js. The function is so scarily long and hard to do unit
test. Is is possible to break it into smaller functions? @tvirot
https://github.com/tvirot

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#24 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEssY66arjaO58akOVSR4iraboNLUSByks5qv-B1gaJpZM4KGeiV
.

[p16i]

Here is my idea. We can separate the logics into STATE and put it in its own file under states directory. For each state, we might have something like this

function POST_A_PIN = {
    return {
        depends: [ WAITING_FOR_LOCATION, WAITING_FOR_IMAGE ]
        next: [ 'SAY_GOODBYE' ]
        onEnter: function(context){ ... }
    }
}

What do you think?
@supasate @tvirot