Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track event callbacks #3

Open
yuhao opened this issue Apr 29, 2016 · 2 comments
Open

Track event callbacks #3

yuhao opened this issue Apr 29, 2016 · 2 comments

Comments

@yuhao
Copy link
Owner

yuhao commented Apr 29, 2016

We can track addEventListener, but do we intercept whenever a callback is triggered? Need to think about various ways that a callback can be registered.

@yuhao
Copy link
Owner Author

yuhao commented May 11, 2016

This patch allows us to intercept callbacks that are registered through addEventListener. This misses events that are added through writing onevent properties.

This article discusses ways that events could be added. Note that events that are added through jQuery eventually call addEventListener.

@yuhao yuhao added the MVP label May 16, 2016
@yuhao
Copy link
Owner Author

yuhao commented May 30, 2016

If a callback is registered through el.onclick = foo, it should already be captured -- we just have to add instrumentation APIs around it.

If an callback is registered inlined within HTML such as <p onclick="foo()">, then we won't be able to capture it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant