Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential error in find_new_objs #139

Open
noelshin opened this issue Apr 8, 2024 · 0 comments
Open

Potential error in find_new_objs #139

noelshin opened this issue Apr 8, 2024 · 0 comments

Comments

@noelshin
Copy link

noelshin commented Apr 8, 2024

First of all, thank you very much for making this code publicly available!

While I was using your code, I noticed that in the find_new_objs function in SegTracker.py (https://github.com/z-x-yang/Segment-and-Track-Anything/blob/main/SegTracker.py#L123) could have an issue regarding modification of new_obj_mask during iteration. In addition, as pointed out in #105, shouldn't obj_num be self.curr_idx + 1 rather than self.curr_idx? Please correct me if I'm mistaken.

Many thanks,
Gyungin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant