Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise (Instead of Warn) on Misconfiguration #47

Open
rringler opened this issue Sep 20, 2019 · 0 comments
Open

Raise (Instead of Warn) on Misconfiguration #47

rringler opened this issue Sep 20, 2019 · 0 comments
Assignees
@mickaelpham
Labels
enhancement New feature or request

Comments

@rringler
Copy link
Contributor

rringler commented Sep 20, 2019 •
edited
Loading

Right now, if a gem user misconfigures their excluded_fields or users file paths, the library will log a warning and then proceed as if the file was empty, which could lead to run-time errors.

It would probably be better if IronBank::Configuration#excluded_fields & IronBank::User.store raised immediately if the the config specifies a file that does not exist.
@rringler rringler added the enhancement New feature or request label Sep 20, 2019
@mickaelpham mickaelpham self-assigned this Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mickaelpham mickaelpham

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rringler @mickaelpham