Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to support 1.21 #67

Open
Electronik21 opened this issue Jun 19, 2024 · 2 comments · May be fixed by #69
Open

Update to support 1.21 #67

Electronik21 opened this issue Jun 19, 2024 · 2 comments · May be fixed by #69

Comments

@Electronik21
Copy link

The plugin doesn't work on Paper 1.21, tested on build 9. When you look at a mob it doesn't show the healthbar, and it spams this error in the console:

[ActionHealth] Task #2 for ActionHealth v3.5.9 generated an exception
java.lang.NullPointerException: Cannot read the array length because "<local2>" is null
        at io.papermc.paper.pluginremap.reflect.PaperReflection.parameterDescriptor(PaperReflection.java:147) ~[paper-1.21.jar:1.21-9-4ea696f]
        at io.papermc.paper.pluginremap.reflect.PaperReflection.strippedMethodKey(PaperReflection.java:141) ~[paper-1.21.jar:1.21-9-4ea696f]
        at io.papermc.paper.pluginremap.reflect.PaperReflection.findMappedMethodName(PaperReflection.java:94) ~[paper-1.21.jar:1.21-9-4ea696f]
        at io.papermc.paper.pluginremap.reflect.PaperReflection.mapMethodName(PaperReflection.java:71) ~[paper-1.21.jar:1.21-9-4ea696f]
        at io.papermc.reflectionrewriter.runtime.AbstractDefaultRulesReflectionProxy.getMethod(AbstractDefaultRulesReflectionProxy.java:100) ~[reflection-rewriter-runtime-0.0.1.jar:?]
        at io.papermc.paper.pluginremap.reflect.PaperReflectionHolder.getMethod(Unknown Source) ~[paper-1.21.jar:1.21-9-4ea696f]
        at ActionHealth-3.5.9-all.jar/com.zeshanaslam.actionhealth.utils.HealthUtil.getNameReflection(HealthUtil.java:245) ~[ActionHealth-3.5.9-all.jar:?]
        at ActionHealth-3.5.9-all.jar/com.zeshanaslam.actionhealth.utils.HealthUtil.getName(HealthUtil.java:222) ~[ActionHealth-3.5.9-all.jar:?]
        at ActionHealth-3.5.9-all.jar/com.zeshanaslam.actionhealth.LookThread.run(LookThread.java:36) ~[ActionHealth-3.5.9-all.jar:?]
        at org.bukkit.craftbukkit.scheduler.CraftTask.run(CraftTask.java:101) ~[paper-1.21.jar:1.21-9-4ea696f]
        at org.bukkit.craftbukkit.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:482) ~[paper-1.21.jar:1.21-9-4ea696f]
        at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1654) ~[paper-1.21.jar:1.21-9-4ea696f]
        at net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:471) ~[paper-1.21.jar:1.21-9-4ea696f]
        at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1538) ~[paper-1.21.jar:1.21-9-4ea696f]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1246) ~[paper-1.21.jar:1.21-9-4ea696f]
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:329) ~[paper-1.21.jar:1.21-9-4ea696f]
        at java.base/java.lang.Thread.run(Thread.java:1570) ~[?:?]

It looks like something to do with Paper using mojang mappings now and remapping the plugins, but I don't know much about plugin development or the server in general
@Aurelien30000 Aurelien30000 mentioned this issue Jul 10, 2024
Closed
@Aurelien30000
Copy link
Contributor

Hi, thanks for the report, looks like a Paper issue, I reported it to the team!
Additionally, I will be making a pull request for full 1.21 support soon.

@Aurelien30000 Aurelien30000 linked a pull request Jul 10, 2024 that will close this issue
Open
@Pro245Mc
Copy link

Pro245Mc commented Oct 2, 2024

Hi there, any news on this update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to 1.21 Aurelien30000/ActionHealth
3 participants
@Aurelien30000 @Electronik21 @Pro245Mc