Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated safety to use 'safety scan' #1737

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Migrated safety to use 'safety scan' #1737

wants to merge 1 commit into from

Conversation

andy-maier
Copy link
Member

@andy-maier andy-maier commented Jan 5, 2025 •
edited
Loading

In this PR, the safety tool is not running. It prompts for creating an account and then terminates without returning an error:

Makefile: Running Safety for install packages (and tolerate safety issues when RUN_TYPE is normal)
rm -f done/safety_install_py3.9_latest.done
bash -c "safety scan --policy-file .safety-policy-install.yml -r minimum-constraints-install.txt --full-report || test 'normal' == 'normal' || exit 1"
Please login or register Safety CLI (free forever) to scan and secure your 
projects with Safety
(R)egister for a free account in 30 seconds, or (L)ogin with an existing account
Unhandled exception happened: EOF when reading a line
to continue (R/L): echo "done" >done/safety_install_py3.9_latest.done
Makefile: Done running Safety for install packages

@andy-maier andy-maier self-assigned this Jan 5, 2025
@andy-maier andy-maier added this to the 1.19.0 milestone Jan 5, 2025
@andy-maier andy-maier linked an issue Jan 5, 2025 that may be closed by this pull request
Migrate safety tool to be called with "safety scan" #1736
Open
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 82.504%. remained the same
when pulling 8c9ff42 on andy/safety-scan
into d55c092 on master.

@andy-maier andy-maier modified the milestones: 1.19.0, 1.20.0 Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@andy-maier andy-maier

Labels
dont merge
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

Migrate safety tool to be called with "safety scan"
2 participants
@andy-maier @coveralls