fix detection of multiple @mentions #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use //g for multiple matches take result from $_ because $1 will always contain the last match
removes error display in debug output on every update when follow_extra is empty
|
why does the second commit already show up here, too? anyways, I don't have to open another pull request then :) The second commit fixes a warning in debug mode that was displayed on every get_updates() when the follow_extra list is empty:
19:06 get_timeline(0= > ) started. username = @Twitter
19:06 Error during user_timeline() call: Aborted.
19:06 : $VAR1 = 'required arg \'id\' missing at ~/.irssi/scripts/twirssi.pl line 1319
19:06 : ';
|
|
pull request has been merged |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use //g for multiple matches
take result from $_ because $1 will always contain the last match
the old code only found the first @mention - and seeing that there is a foreach loop, this does not seem to be intended