From ad592f73d7c245f530f428af786ee39042208784 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Viktor=20S=C3=B6derqvist?= Date: Sun, 12 Jan 2025 01:02:39 +0100 Subject: [PATCH] Skip CLI tests with reply schema validation (#1545) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The commands used in valkey-cli tests are not important the reply schema validation. Skip them to avoid the problem if tests hanging. This has failed lately in the daily job: ``` [TIMEOUT]: clients state report follows. sock55fedcc19be0 => (IN PROGRESS) valkey-cli pubsub mode with single standard channel subscription Killing still running Valkey server 33357 ``` These test cases use a special valkey-cli command `:get pubsub` command, which is an internal command to valkey-cli rather than a Valkey server command. This command hangs when compiled with with logreqres enabled. Easy solution is to skip the tests in this setup. The test cases were introduced in #1432. Signed-off-by: Viktor Söderqvist --- tests/integration/valkey-cli.tcl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/integration/valkey-cli.tcl b/tests/integration/valkey-cli.tcl index 095f1e77bc..d4adf9c071 100644 --- a/tests/integration/valkey-cli.tcl +++ b/tests/integration/valkey-cli.tcl @@ -6,7 +6,7 @@ if {$::singledb} { set ::dbnum 9 } -start_server {tags {"cli"}} { +start_server {tags {"cli logreqres:skip"}} { proc open_cli {{opts ""} {infile ""}} { if { $opts == "" } { set opts "-n $::dbnum"