Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat Basic CC currentValue without targetValue as a numeric (?) sensor instead of a light #28

Closed
AlCalzone opened this issue Nov 30, 2023 · 6 comments

Comments

@AlCalzone
Copy link
Member

The recent changes to Basic CC exposed an issue where devices that "support" Basic CC, but cannot actually be controlled, appear as a light entity. The next version of node-zwave-js only exposes currentValue in this case.

This needs a change in the discovery scheme, so that currentValue without targetValue is considered a sensor and not a light/actor.

@raman325
Copy link
Collaborator

raman325 commented Dec 6, 2023

got a device dump I can use?

@raman325
Copy link
Collaborator

raman325 commented Dec 6, 2023

also is this going to require a reinterview?

@AlCalzone
Copy link
Member Author

Do you have an Aeotec Multisensor 6 or something similar? That should exhibit the behavior.
I think it might require a re-interview too because the Basic CC support information needs to be set correctly.

@raman325
Copy link
Collaborator

raman325 commented Dec 9, 2023

Do you have an Aeotec Multisensor 6 or something similar? That should exhibit the behavior. I think it might require a re-interview too because the Basic CC support information needs to be set correctly.

I don't but it's fine, I will take the existing Aeotec Multisensor 6 dump and modify it for this purpose

@marcelveldt
Copy link
Collaborator

marcelveldt commented Apr 11, 2024

We had a little chat about this and came to a few conclusions;

  • - The driver should hide Basic CC when it knows for certain there's a better alternative
  • - We should create a sensor from Basic CC without targetValue
  • - We should create switch + number entity for Basic CC with targetValue
  • - We should not abuse light platform for Basic CC
  • - Nice to have would be that the device database can include info when to hide Basic CC

@marcelveldt marcelveldt moved this from Triage to Later in Z-Wave JS: Road to Certification Apr 11, 2024
@AlCalzone
Copy link
Member Author

Regarding the 1st point:

...so I consider that done - the rest is on the HA side.

@marcelveldt marcelveldt moved this from Later to In Progress in Z-Wave JS: Road to Certification Jul 4, 2024
@AlCalzone AlCalzone moved this from In Progress to Done/verify in Z-Wave JS: Road to Certification Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants