Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect pitch on mobile devices #8

Open
earboxer opened this issue Jun 23, 2020 · 2 comments
Open

Incorrect pitch on mobile devices #8

earboxer opened this issue Jun 23, 2020 · 2 comments

Comments

@earboxer
Copy link
Contributor

See rism-digital/midi-player#21

This also applies on http://zz85.github.io/wild-web-midi, but not when "Run WAV Converter" is used.

14725 added a commit to 14725/wild-web-midi that referenced this issue Jan 23, 2021
Make the "sampleRate" of the "AudioContext" and the "CircularAudioBuffer" matched.
@14725
Copy link

14725 commented Jan 23, 2021

At least for this one...

audioCtx = new window.AudioContext();

if we change it into

   audioCtx = new window.AudioContext({sampleRate:SAMPLE_RATE});

it will work, at least on my PC.

However the MDN says that the support of 'sampleRate" for AudioContext starts from Chorme 74. Is the support came early enough so that we can apply it safety?

@efreja
Copy link

efreja commented Feb 14, 2021

Tested this fix in rism-digital/midi-player, and it solves the problem. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants