Merge pull request #178 from 00sOrg/Feat/177

✨ [Feat] Implement delete event api

src/common/api/status/error.status.ts

@@ -97,6 +97,11 @@ export class ErrorStatus implements BaseCode {
     400,
     '주소를 찾을 수 없습니다.',
   );
+  static readonly EVENT_NOT_OWNER = new ErrorStatus(
+    false,
+    400,
+    '이벤트의 소유자가 아닙니다.',
+  );
 
   //S3 에러
   static readonly S3_UPLOAD_FAILURE = new ErrorStatus(
@@ -127,4 +132,10 @@ export class ErrorStatus implements BaseCode {
     400,
     'Push 메시지를 보내는데 실패했습니다',
   );
+
+  static readonly S3_DELETE_FAILURE = new ErrorStatus(
+    false,
+    400,
+    '이미지 삭제에 실패했습니다.',
+  );
 }

src/external/s3/s3.service.ts

@@ -1,4 +1,8 @@
-import { PutObjectCommand, S3Client } from '@aws-sdk/client-s3';
+import {
+  DeleteObjectCommand,
+  PutObjectCommand,
+  S3Client,
+} from '@aws-sdk/client-s3';
 import { Injectable } from '@nestjs/common';
 import { ConfigService } from '@nestjs/config';
 import { ErrorStatus } from 'src/common/api/status/error.status';
@@ -43,4 +47,18 @@ export class S3Service {
     const region = this.configService.get<string>('BUCKET_REGION');
     return `https://${bucketName}.s3.${region}.amazonaws.com/${key}`;
   }
+
+  async delete(key: string): Promise<void> {
+    const data = {
+      Bucket: this.configService.get<string>('BUCKET_NAME'),
+      Key: key,
+    };
+
+    try {
+      const command = new DeleteObjectCommand(data);
+      await this.s3Client.send(command);
+    } catch (error) {
+      throw new ExceptionHandler(ErrorStatus.S3_DELETE_FAILURE);
+    }
+  }
 }

src/modules/events/entities/comment.entity.ts

@@ -14,11 +14,11 @@ export class Comment extends DefaultEntity {
   @PrimaryGeneratedColumn({ type: 'bigint' })
   id!: number;
 
-  @ManyToOne(() => Event)
+  @ManyToOne(() => Event, { onDelete: 'CASCADE' })
   @JoinColumn()
   event!: Event;
 
-  @ManyToOne(() => Member)
+  @ManyToOne(() => Member, { onDelete: 'CASCADE' })
   @JoinColumn()
   member!: Member;
 

src/modules/events/events.controller.ts

@@ -9,6 +9,7 @@ import {
   Query,
   UseInterceptors,
   UploadedFile,
+  Delete,
 } from '@nestjs/common';
 import { EventsService } from './services/events.service';
 import { CreateEventDto } from './dto/create-event.dto';
@@ -235,4 +236,17 @@ export class EventsController {
     const member = req.user;
     return await this.eventsService.getEvents(member);
   }
+
+  @Delete(':id(\\d+)')
+  @ApiOperation({ summary: '이벤트 삭제' })
+  @ApiSuccessResponse()
+  @ApiFailureResponse(
+    ErrorStatus.EVENT_NOT_FOUND,
+    ErrorStatus.INTERNAL_SERVER_ERROR,
+    ErrorStatus.S3_DELETE_FAILURE,
+  )
+  async deleteEvent(@Param('id') id: string, @Request() req) {
+    const member = req.user;
+    await this.eventsService.deleteEvent(Number(id), member);
+  }
 }

src/modules/events/repository/events.repository.ts

@@ -104,4 +104,8 @@ export class EventsRepository {
       .where('event.memberId = :memberId', { memberId })
       .getMany();
   }
+
+  async delete(event: Event): Promise<void> {
+    await this.eventRepository.delete({ id: event.id });
+  }
 }

src/modules/events/services/events.service.ts

@@ -167,6 +167,20 @@ export class EventsService {
     return GetEventsDto.of(events);
   }
 
+  async deleteEvent(eventId: number, member: Member) {
+    const event = await this.eventsRepository.findById(eventId);
+    if (!event) {
+      throw new ExceptionHandler(ErrorStatus.EVENT_NOT_FOUND);
+    }
+    if (event.member.id !== member.id) {
+      throw new ExceptionHandler(ErrorStatus.EVENT_NOT_OWNER);
+    }
+    if (event.media) {
+      await this.s3Service.delete(event.media);
+    }
+    await this.eventsRepository.delete(event);
+  }
+
   private isValidLocation(lat: number, lng: number) {
     if (
       lat === undefined ||

test/unit/events.service.spec.ts

@@ -59,6 +59,7 @@ describe('EventService', () => {
             update: jest.fn(),
             findByTitleLike: jest.fn(),
             findAllByMember: jest.fn(),
+            delete: jest.fn(),
           },
         },
         {
@@ -71,6 +72,7 @@ describe('EventService', () => {
           provide: S3Service,
           useValue: {
             upload: jest.fn(),
+            delete: jest.fn(),
           },
         },
         {
@@ -556,4 +558,35 @@ describe('EventService', () => {
       expect(result).toEqual(getEventsDto);
     });
   });
+
+  describe('deleteEvent', () => {
+    let event: Event;
+    let member: Member;
+    beforeEach(() => {
+      member = new MemberBuilder().id(1).build();
+      event = new EventBuilder().id(1).member(member).media('test').build();
+    });
+    it('should delete the event successfully', async () => {
+      jest.spyOn(eventsRepository, 'findById').mockResolvedValue(event);
+      jest.spyOn(s3Service, 'delete').mockResolvedValue(undefined);
+      jest.spyOn(eventsRepository, 'delete').mockResolvedValue(undefined);
+      await eventsService.deleteEvent(event.id, member);
+      expect(eventsRepository.findById).toHaveBeenCalledWith(event.id);
+      expect(s3Service.delete).toHaveBeenCalledWith(event.media);
+      expect(eventsRepository.delete).toHaveBeenCalledWith(event);
+    });
+    it('should throw EVENT_NOT_FOUND if the event is not found', async () => {
+      jest.spyOn(eventsRepository, 'findById').mockResolvedValue(null);
+      await expect(eventsService.deleteEvent(event.id, member)).rejects.toThrow(
+        new ExceptionHandler(ErrorStatus.EVENT_NOT_FOUND),
+      );
+    });
+    it('should throw EVENT_NOT_OWNER if the member is not the owner of the event', async () => {
+      const anotherMember = new MemberBuilder().id(2).build();
+      jest.spyOn(eventsRepository, 'findById').mockResolvedValue(event);
+      await expect(
+        eventsService.deleteEvent(event.id, anotherMember),
+      ).rejects.toThrow(new ExceptionHandler(ErrorStatus.EVENT_NOT_OWNER));
+    });
+  });
 });