Add x/escrow #2

0Tech · 2024-01-24T13:53:47Z

Summary by CodeRabbit

New Features
- Introduced an escrow module facilitating secure transactions between multiple parties.
- Added Docker support for running binaries and development tasks.
- Implemented GitHub Actions workflow for automated linting, building, testing, and formatting.
Enhancements
- Added support for managing Go projects with CMake.
- Enhanced project setup with options for color output and test configurations.
Documentation
- Updated README.md files with project descriptions and module information.
Bug Fixes
- Added the /build directory to .gitignore to prevent tracking build artifacts.
Tests
- Added extensive testing for the escrow module, including action execution and proposal submission.
Chores
- Improved linting configurations for Go projects with specific settings for various linters.

coderabbitai

Review Status

Actionable comments generated: 2

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between ea8ef4e and dc34bec.

Files selected for processing (21)

.github/workflows/module.yml (1 hunks)
CMakeLists.txt (1 hunks)
builders/CMakeLists.txt (1 hunks)
builders/bare/CMakeLists.txt (1 hunks)
builders/bare/install/CMakeLists.txt (1 hunks)
builders/bare/install/buf.cmake (1 hunks)
builders/bare/install/common.cmake (1 hunks)
builders/bare/install/go.cmake (1 hunks)
builders/bare/install/golangci-lint.cmake (1 hunks)
builders/bare/install/protoc-gen-go-grpc.cmake (1 hunks)
builders/bare/install/protoc-gen-go-pulsar.cmake (1 hunks)
builders/bare/install/protoc-gen-go.cmake (1 hunks)
builders/bare/install/protoc-gen-gocosmos.cmake (1 hunks)
builders/bare/install/protoc-gen-grpc-gateway.cmake (1 hunks)
builders/bare/targets/CMakeLists.txt (1 hunks)
builders/docker/CMakeLists.txt (1 hunks)
builders/docker/install/CMakeLists.txt (1 hunks)
builders/docker/install/Dockerfile.in (1 hunks)
builders/docker/install/docker-build.cmake (1 hunks)
builders/docker/targets/CMakeLists.txt (1 hunks)
builders/docker/targets/docker-run.cmake (1 hunks)

Files skipped from review as they are similar to previous changes (2)

.github/workflows/module.yml
CMakeLists.txt

Additional comments: 17

builders/bare/CMakeLists.txt (1)

1-2: LGTM!

builders/docker/CMakeLists.txt (1)

1-2: LGTM!

builders/docker/install/docker-build.cmake (1)

1-6: Ensure ${IDFILE} is defined before executing this script.

builders/docker/targets/docker-run.cmake (1)

1-6: Ensure ${IDFILE}, ${SOURCE_DIR_SRC}, ${SOURCE_DIR_DST}, ${BINARY_DIR_SRC}, and ${BINARY_DIR_DST} are defined before executing this script.

builders/bare/install/protoc-gen-gocosmos.cmake (1)

1-19: Ensure VERSION is defined and common.cmake correctly sets up the environment for this script.

builders/bare/install/protoc-gen-go-pulsar.cmake (1)

1-19: Ensure VERSION is defined and common.cmake correctly sets up the environment for this script.

builders/bare/install/protoc-gen-grpc-gateway.cmake (1)

1-19: Ensure VERSION is defined and common.cmake correctly sets up the environment for this script.

builders/bare/install/buf.cmake (1)

1-29: Ensure VERSION is defined and common.cmake correctly sets up the environment for this script.

builders/bare/install/protoc-gen-go.cmake (1)

1-30: Ensure VERSION is defined and common.cmake correctly sets up the environment for this script.

builders/bare/install/protoc-gen-go-grpc.cmake (1)

1-30: Ensure VERSION is defined and common.cmake correctly sets up the environment for this script.

builders/bare/install/golangci-lint.cmake (1)

1-31: Ensure VERSION is defined and common.cmake correctly sets up the environment for this script.

builders/bare/install/common.cmake (1)

1-27: LGTM!

builders/docker/install/Dockerfile.in (1)

1-29: LGTM!

builders/docker/install/CMakeLists.txt (1)

1-26: Ensure ${CMAKE_CURRENT_SOURCE_DIR}/docker-build.cmake exists and is correctly set up for this context.

builders/docker/targets/CMakeLists.txt (1)

1-64: LGTM!

builders/bare/install/CMakeLists.txt (1)

1-73: LGTM!

builders/bare/targets/CMakeLists.txt (1)

1-155: LGTM!

builders/CMakeLists.txt

builders/bare/install/go.cmake

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between dc34bec and 81e51b4.

Files selected for processing (2)

x/escrow/keeper/internal/keeper_test.go (1 hunks)
x/escrow/keeper/internal/proposal.go (1 hunks)

Files skipped from review as they are similar to previous changes (2)

x/escrow/keeper/internal/keeper_test.go
x/escrow/keeper/internal/proposal.go

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 81e51b4 and c4f0d32.

Files selected for processing (5)

.github/workflows/module.yml (1 hunks)
.github/workflows/modules.yml (1 hunks)
builders/docker/install/CMakeLists.txt (1 hunks)
builders/docker/install/Dockerfile (1 hunks)
builders/docker/install/docker-build.cmake (1 hunks)

Files skipped from review as they are similar to previous changes (3)

.github/workflows/module.yml
builders/docker/install/CMakeLists.txt
builders/docker/install/docker-build.cmake

Additional comments: 2

.github/workflows/modules.yml (1)

1-21: The workflow file correctly defines a job matrix for module checks, including the new escrow module. Ensure that SONAR_TOKEN_X_ESCROW is properly set in the repository's secrets.

builders/docker/install/Dockerfile (1)

1-29: The Dockerfile follows best practices with a multi-stage build, minimizing layers, and setting up a non-root user for security. Ensure that the UID and GID build arguments are provided during the build process.

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 81e51b4 and d2870ff.

Files ignored due to path filters (2)

x/escrow/proto/buf.yaml is excluded by: !**/*.yaml
x/test/proto/buf.yaml is excluded by: !**/*.yaml

Files selected for processing (5)

.github/workflows/module.yml (1 hunks)
.github/workflows/modules.yml (1 hunks)
builders/docker/install/CMakeLists.txt (1 hunks)
builders/docker/install/Dockerfile (1 hunks)
builders/docker/install/docker-build.cmake (1 hunks)

Files skipped from review as they are similar to previous changes (5)

.github/workflows/module.yml
.github/workflows/modules.yml
builders/docker/install/CMakeLists.txt
builders/docker/install/Dockerfile
builders/docker/install/docker-build.cmake

coderabbitai

Review Status

Actionable comments generated: 11

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between d2870ff and 57ba778.

Files selected for processing (6)

x/escrow/keeper/internal/genesis_test.go (1 hunks)
x/escrow/keeper/internal/grpc_query_test.go (1 hunks)
x/escrow/keeper/internal/keeper_test.go (1 hunks)
x/escrow/keeper/internal/msg_server_test.go (1 hunks)
x/escrow/keeper/internal/proposal_test.go (1 hunks)
x/escrow/module/autocli.go (1 hunks)

Files skipped from review as they are similar to previous changes (4)

x/escrow/keeper/internal/genesis_test.go
x/escrow/keeper/internal/keeper_test.go
x/escrow/keeper/internal/msg_server_test.go
x/escrow/module/autocli.go

x/escrow/keeper/internal/proposal_test.go

x/escrow/keeper/internal/grpc_query_test.go

coderabbitai

Review Status

Actionable comments generated: 5

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 57ba778 and 4fc5ea9.

Files selected for processing (8)

app/.golangci.yaml (1 hunks)
builders/bare/install/CMakeLists.txt (1 hunks)
builders/bare/install/go.cmake (1 hunks)
cmd/and/.golangci.yaml (1 hunks)
x/escrow/.golangci.yaml (1 hunks)
x/escrow/keeper/internal/agent_test.go (1 hunks)
x/escrow/keeper/internal/genesis_test.go (1 hunks)
x/escrow/keeper/internal/proposal_test.go (1 hunks)

Files skipped from review as they are similar to previous changes (4)

builders/bare/install/CMakeLists.txt
builders/bare/install/go.cmake
x/escrow/keeper/internal/genesis_test.go
x/escrow/keeper/internal/proposal_test.go

Additional comments: 7

app/.golangci.yaml (2)

19-27: The custom order for imports specified in gci linter settings is good for maintaining consistency. Verify that the specified prefixes align with the project's dependencies.

28-38: depguard settings correctly specify allowed dependencies. Ensure that all necessary dependencies are included and that the list is up-to-date with the project's requirements.

cmd/and/.golangci.yaml (2)

19-27: The custom order for imports specified in gci linter settings is good for maintaining consistency. Verify that the specified prefixes align with the project's dependencies.

28-40: depguard settings correctly specify allowed dependencies for the cmd/and directory, including CLI-specific libraries. Ensure that all necessary dependencies are included and that the list is up-to-date with the project's requirements.

x/escrow/.golangci.yaml (3)

3-7: Skipping generated files and mocks in linting is a good practice. Verify that all patterns for skipped files match the project's file naming conventions.

25-33: The custom order for imports specified in gci linter settings is good for maintaining consistency. Verify that the specified prefixes align with the project's dependencies.

34-59: depguard settings correctly specify allowed dependencies for both main and test files. Ensure that all necessary dependencies are included and that the list is up-to-date with the project's requirements.

app/.golangci.yaml

cmd/and/.golangci.yaml

x/escrow/keeper/internal/agent_test.go

x/escrow/.golangci.yaml

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 4fc5ea9 and fcc9900.

Files selected for processing (2)

x/escrow/keeper/internal/keeper_test.go (1 hunks)
x/escrow/keeper/internal/proposal_test.go (1 hunks)

Files skipped from review as they are similar to previous changes (2)

x/escrow/keeper/internal/keeper_test.go
x/escrow/keeper/internal/proposal_test.go

sonarqubecloud · 2024-02-15T11:03:55Z

Quality Gate passed for '0tech_andromeda_x-test'

Issues
0 New issues

Measures
0 Security Hotspots
84.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud · 2024-02-15T11:04:05Z

Quality Gate passed for '0tech_andromeda_x-escrow'

Issues
1 New issue

Measures
0 Security Hotspots
81.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

* Update x/test README.md * Update x/escrow README.md * Update cosmos-sdk links * Improve abstract and add more examples * Fix section depth * Use colons * Add go report cards * Add a status badge of `Check Modules`

0Tech added 12 commits January 21, 2024 11:17

Implement x/escrow prototype

e35b90e

Implement app

cd44da2

Implement cmd

990ce3a

Implement x/test

bff7ddf

Use x/test in tests

202c652

Add documentations

ceaaa36

Do go mod tidy

537519d

Add metadata

ce4daea

Update documentation

4608f25

Update x/test documentation

d1ab23c

Make assets prefix configurable so the consumer can avoid collision

76bcac5

Add minimal build configuration

89e2f28

0Tech linked an issue Jan 24, 2024 that may be closed by this pull request

Add x/escrow #1

Closed

0Tech self-assigned this Jan 24, 2024

0Tech force-pushed the 1-add-xescrow branch 16 times, most recently from f3bd2ec to c9b971f Compare January 25, 2024 04:01

0Tech added 2 commits February 13, 2024 12:13

Check inputs in scripts

2fa70d7

Rename builder folder

dc34bec

0Tech force-pushed the 1-add-xescrow branch from 1d38e3d to dc34bec Compare February 13, 2024 12:14

coderabbitai bot reviewed Feb 13, 2024

View reviewed changes

builders/CMakeLists.txt Show resolved Hide resolved

builders/bare/install/go.cmake Outdated Show resolved Hide resolved

0Tech added 2 commits February 13, 2024 12:29

Document the function for the temporary solution

3bcc9b2

Use crypto/rand

81e51b4

coderabbitai bot reviewed Feb 13, 2024

View reviewed changes

0Tech force-pushed the 1-add-xescrow branch from c94b990 to c4f0d32 Compare February 14, 2024 03:40

coderabbitai bot reviewed Feb 14, 2024

View reviewed changes

0Tech added 2 commits February 14, 2024 12:02

Update buf lint config

14e8a43

Fix workflow

d2870ff

0Tech force-pushed the 1-add-xescrow branch from c4f0d32 to d2870ff Compare February 14, 2024 12:27

coderabbitai bot reviewed Feb 14, 2024

View reviewed changes

0Tech added 2 commits February 14, 2024 13:04

Update address creations

df29a95

Refactor AutoCLIOptions

57ba778

coderabbitai bot reviewed Feb 14, 2024

View reviewed changes

0Tech added 3 commits February 15, 2024 03:14

Update go lint config

b6f7d64

Don't check the return value in case of error

c5bde2e

Fix hard coded download url

4fc5ea9

coderabbitai bot reviewed Feb 15, 2024

View reviewed changes

app/.golangci.yaml Show resolved Hide resolved

cmd/and/.golangci.yaml Show resolved Hide resolved

x/escrow/keeper/internal/agent_test.go Show resolved Hide resolved

x/escrow/keeper/internal/agent_test.go Show resolved Hide resolved

x/escrow/.golangci.yaml Show resolved Hide resolved

Ensure input validness right before the test

fcc9900

coderabbitai bot reviewed Feb 15, 2024

View reviewed changes

0Tech mentioned this pull request Feb 15, 2024

Fix handling nil actions #5

Open

0Tech merged commit f405ccd into main Feb 15, 2024
12 checks passed

0Tech added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 16, 2024

0Tech mentioned this pull request Feb 16, 2024

Update documentation on #2 #10

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add x/escrow #2

Add x/escrow #2

0Tech commented Jan 24, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

sonarqubecloud bot commented Feb 15, 2024

sonarqubecloud bot commented Feb 15, 2024

Add x/escrow #2

Add x/escrow #2

Conversation

0Tech commented Jan 24, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Feb 15, 2024

Quality Gate passed for '0tech_andromeda_x-test'

sonarqubecloud bot commented Feb 15, 2024

Quality Gate passed for '0tech_andromeda_x-escrow'

0Tech commented Jan 24, 2024 •

edited by coderabbitai bot

Loading