Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add gas price estimation feature to zcnbridge #1428

Merged
merged 19 commits into from
Mar 17, 2024

Conversation

YarikRevich
Copy link
Collaborator

@YarikRevich YarikRevich commented Mar 15, 2024

No description provided.

@YarikRevich YarikRevich self-assigned this Mar 15, 2024
@YarikRevich YarikRevich added the enhancement New feature or request label Mar 15, 2024
@YarikRevich YarikRevich linked an issue Mar 15, 2024 that may be closed by this pull request
infuraEthereumNodeURL = "https://mainnet.infura.io/v3/7238211010344719ad14a89db874158c"
value = 1e+10

password = "02289b9"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put the info above into github ENVs or SECRETS

Copy link
Collaborator Author

@YarikRevich YarikRevich Mar 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The given data is fake, there is not security issue.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used only for tests

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YarikRevich YarikRevich merged commit 973aeb0 into sprint-1.14 Mar 17, 2024
10 checks passed
@YarikRevich YarikRevich deleted the feature/gas-estimation-alchemy branch March 17, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: add gas price estimation feature to zcnbridge
2 participants