-
-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated zoom slider style #318
base: master
Are you sure you want to change the base?
Conversation
This reverts commit 88d77b3.
Why do we need a new style here? Can you explain a little bit? |
The new style looks like the zoom slider from word, wordpad. It makes more sense and also looks aesthetically pleasing. |
Ok, first, thanks for doing this and it looks not bad to me. There are two concerns I have:
I would suggest let's keep using default control as much as possible and make it easier for us in terms of time and also overall consistency. |
I have only removed the tint and modified the thumb design, this shouldn't cause any issue in older systems or in future. |
I am planning to use WinUI at certain point so I wan to keep resource changes as minimum as possible. We should use default design as much as possible for consistency as well unless it is not functional or needed by app logic/ux. Just my 2 cents here. |
Let's wait for WinUI to become solid before merging. I don't see it drastically better than what we have right now. |
No description provided.