This repository has been archived by the owner on Nov 4, 2020. It is now read-only.
forked from social-dist0rtion-protocol/planet-a
-
-
Notifications
You must be signed in to change notification settings - Fork 2
Store voting history in local storage #64
Open
MaxStalker
wants to merge
4
commits into
master
Choose a base branch
from
fix/history-view
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannbarbie
suggested changes
Sep 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dangerous use of js number for things that should be BN.
history.map(item => { | ||
const {type, votes, proposalId, timestamp} = item; | ||
let suffix = "Voice Credit"; | ||
if (Math.abs(votes) !== 1 ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
always use BN
// Store voting action in history | ||
this.storeVotingAction({ | ||
type: "cast", | ||
votes: sign * newVotesTotal, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
always use BN
// Store voting action in history | ||
this.storeVotingAction({ | ||
type: "withdraw", | ||
votes: parseInt(votes), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only use BN
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing it now..