This repository has been archived by the owner on Nov 4, 2020. It is now read-only.
Add global error handler #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimDaub
reviewed
Sep 6, 2019
Yeah I can do it. I think Sentry is a better approach than showing the error to the end user. Should I close this PR in favor of #80? |
No, still need to show meaningful error message to user (so we can distinguish) + ideally log a stack trace to the server. |
troggy
approved these changes
Sep 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #91
It looks like this:
If you open details, you'll see the actual stacktrace... 🎉 SOURCEMAPPED 🎉
I see the sourcemap is served also in production, so everything should work as expected.
The call to action for the error is "let us know" and "copy to clipboard". If you have better ideas for it please tell me.