ENG-5293 feat(launchpad,1ui,graphql): bring protocol points query into graphql and basic scaffolding of points route #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,27 @@ | |||
| query GetFeeTransfers($address: String!, $cutoff_timestamp: bigint) { | |||
There was a problem hiding this comment.
Nice! Do you think it makes more sense to name this GetFeeTransfersAggregate or do you think that fee transfers will always just be the aggregate?
I guess the question would be if we ever see this query having more than just the aggregate values.
Nice job!
There was a problem hiding this comment.
I imagine it'll always be an aggregate. Maybe just leave it as is for now and we can modify it in the future, if there is ever a need.
jonathanprozzi
approved these changes
Jan 3, 2025
…ol-points-query-into-graphql-package Signed-off-by: Vital <[email protected]>
Vitalsine85
deleted the
vital/eng-5293-bring-raw-protocol-points-query-into-graphql-package
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected Packages
Apps
Packages
Tools
Overview
Brings the protocol points query into the graphql package. Basic scaffolding of the points route with updated aggregated metrics component. Query for relic points on points route.
Note: Tried setting up api package in launchpad so that we could query for the other points, but realized that we'd have to set up privy for auth. Will pick this back up after talking with the rest of the team.
Screen Captures
If applicable, add screenshots or screen captures of your changes.
Declaration