Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-5587 feat(launchpad): logout privy if no wallet connected #1060

Conversation

Vitalsine85
Copy link
Member

Affected Packages

Apps

  • data populator
  • portal
  • template
  • launchpad

Packages

  • 1ui
  • api
  • graphql
  • protocol
  • sdk

Tools

  • tools

Overview

Handles Privy session based on if the client has connected a wallet. If there is no wallet connected, it will force a logout of Privy.

Screen Captures

If applicable, add screenshots or screen captures of your changes.

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

@github-actions github-actions bot added the feat Feature label Jan 23, 2025
@Vitalsine85 Vitalsine85 changed the title ENG-5587 feat(launchpad): logout privy if no wallet disconnected ENG-5587 feat(launchpad): logout privy if no wallet connected Jan 23, 2025
Copy link
Member

@jonathanprozzi jonathanprozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - approved but try to remove console logs first. If this is blocking just merge and we'll fix after

apps/launchpad/app/.client/privy-logout.tsx Outdated Show resolved Hide resolved
@Vitalsine85 Vitalsine85 force-pushed the vital/eng-5587-wallet-connected-even-though-wallet-is-not-connected-shows branch from cd3ed50 to bace059 Compare January 23, 2025 23:01
@Vitalsine85 Vitalsine85 merged commit 222a4df into feature/launchpad Jan 23, 2025
2 checks passed
@Vitalsine85 Vitalsine85 deleted the vital/eng-5587-wallet-connected-even-though-wallet-is-not-connected-shows branch January 23, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants