ENG-5594 fix(launchpad): fix validation errors in create step #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }) | ||
| return false | ||
| } | ||
| // TODO: Figure out why validation isn't working in this block |
There was a problem hiding this comment.
Thanks for comment! We can think through it more
| @@ -152,7 +161,31 @@ export function CreateStep({ onCreationSuccess }: CreateStepProps) { | |||
| } | |||
|
|
|||
| const handleDepositSubmit = async (data: DepositFormData) => { | |||
| console.log('handleDepositSubmit called with data:', data) | |||
There was a problem hiding this comment.
Let's remove or use logger
| +formatUnits(BigInt(atomCost ?? '0'), 18) + +data.amount | ||
| ).toString() | ||
|
|
||
| console.log('Debug validation:', { |
jonathanprozzi
approved these changes
Jan 24, 2025
Vitalsine85
deleted the
vital/eng-5594-didnt-have-enough-testnet-eth-for-the-atom-creation-but-had
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected Packages
Apps
Packages
Tools
Overview
Validation errors weren't rendering on the create step, specifically if a user had insufficient funds. Moved the check outside of the zod schema. Should revisit to figure out ideal pattern, just wanted to get this in to move QA forward.
Screen Captures
If applicable, add screenshots or screen captures of your changes.
Declaration