Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-0000 fix(repo): fixes lint, typecheck, and build issues in pnpm-lock.yaml drift #879

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

jonathanprozzi
Copy link
Member

@jonathanprozzi jonathanprozzi commented Oct 31, 2024

Affected Packages

Apps

  • portal
  • repo

Packages

  • 1ui
  • api
  • protocol
  • sdk

Tools

  • tools

Overview

  • Started from last known working pnpm-lock.yaml
  • Reinstalled node_modules with that working state, which then only pulled in the few updates we actually needed since last working version
  • I confirmed all updates are working (including the @privy-io/react-auth bump for data-populator) and lint, typecheck, build all work
  • Seems the issue was with installing them all from scratch — the ^ deps were all mismatching w/o previous working one as a reference

Screen Captures

If applicable, add screenshots or screen captures of your changes.

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

@github-actions github-actions bot added the fix Fix label Oct 31, 2024
@jonathanprozzi jonathanprozzi marked this pull request as draft October 31, 2024 04:14
@jonathanprozzi jonathanprozzi marked this pull request as ready for review October 31, 2024 16:06
@jonathanprozzi jonathanprozzi merged commit f054769 into main Oct 31, 2024
3 checks passed
@jonathanprozzi jonathanprozzi deleted the eng-000-fix-lint-typecheck-dep-issues branch October 31, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants