-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENG-4383 feat(portal,1ui): claim & identity cards/rows #884
Conversation
ENG-4383 [🍉] Claim Cards
This ticket focuses on interactive Claim Cards, which will lay the groundwork for future cards, such as Identity Cards, Activity Cards, and Trust Circle Cards. With Claim Cards, users can stake directly from the card itself and access key information through hover actions, reducing the need to navigate to the Claim Detail Page for basic interactions. Claim Card, Claim card for List & Identity Card Screenshot 2024-10-07 at 5.39.56 PM.png Activity Cards Screenshot 2024-10-07 at 5.40.19 PM.png Types
Claim Card + Claim Card for Lists
Identity Card
Activity Card
Mobile
↳ Claim Card - Features (Figma) What's missing:
TVL Molecule - 2 Context Menu - https://github.com/shadcn-ui/ui/blob/main/apps/www/app/(app)/examples/tasks/components/data-table-row-actions.tsx - 3 Stake Buttons (Portal w/ state) - 5 |
Looking good -- 2 minor callouts:
|
cd92d36
to
17ca47c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good -- once the 2 callouts are fixed we are good to go!
07bd8db
to
2ff127e
Compare
Affected Packages
Apps
Packages
Tools
Overview
Note: During this, I noticed that a bunch of terminology/nomenclature used in 1ui is confusing or could be better. Once this is in I will rebase my 1ui re-org branch and probably make a few changes to improve this. i.e. 'numPositions' was labeled 'numFollowers'. There were a lot of cases where we could improve some of this. I think it was just a lack of understanding when some of these components were built out in 1ui. Could also leverage types better as well in some places. I'm assuming the types were added after some of these were built.
Screen Captures
https://www.loom.com/share/8a9cb65d178848aaa12048d26d816d1b?sid=e689d1e4-1ab3-4e97-8a6b-26580b1c3fa4
https://www.loom.com/share/59978a9b08bf4a41b62ec577260efec9?sid=f2aaf1ae-3bc2-4256-9c27-1d84f94238bf
Declaration