Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENG-4659 feat(portal): set up hydration boundary in portal provider #888

Merged
merged 3 commits into from
Nov 7, 2024
Merged

ENG-4659 feat(portal): set up hydration boundary in portal provider #888

merged 3 commits into from
Nov 7, 2024

Conversation

jonathanprozzi
Copy link
Member

Affected Packages

Apps

  • data populator
  • portal
  • template

Packages

  • 1ui
  • api
  • graphql
  • protocol
  • sdk

Tools

  • tools

Overview

  • Adds in the HydrationBoundary in the providers.tsx -- this enables the partial hydration pattern referenced in ENG-4634 feat(repo): adds initial data hydration pattern to template playground routes #885
  • Once this wraps Portal via the providers we can partially hydrate as long as the queryKey matches server + client side. This won't have any bearing on our client-side only hooks such as in modals but enables the hydration pattern where loaders are available
  • The HydrationBoundary ensures that our client-side cache for each query (where loaders are available) starts with the same data that was fetched and rendered on the server

Screen Captures

If applicable, add screenshots or screen captures of your changes.

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

@linear Linear
Copy link

linear bot commented Nov 6, 2024

ENG-4659 Set up HydrationBoundary and hydration client on Portal

TLDR:

Functional Requirement(s):

Task Breakdown - should translate to sub-issues if applicable:

  • [ ]

@github-actions github-actions bot added the feat Feature label Nov 6, 2024
@jonathanprozzi jonathanprozzi enabled auto-merge (squash) November 7, 2024 01:23
@jonathanprozzi jonathanprozzi merged commit 90c148e into main Nov 7, 2024
3 checks passed
@jonathanprozzi jonathanprozzi deleted the eng-4659-set-up-hydration-boundary branch November 7, 2024 01:24
Vitalsine85 added a commit that referenced this pull request Nov 7, 2024
@Vitalsine85
Revert "ENG-4659 feat(portal): set up hydration boundary in portal pr…
0097811 
…ovider (#888)"

This reverts commit 90c148e.
@linear linear bot mentioned this pull request Nov 7, 2024
Merged
10 tasks
@jonathanprozzi jonathanprozzi mentioned this pull request Nov 9, 2024
Merged
10 tasks
jonathanprozzi added a commit that referenced this pull request Nov 9, 2024
@jonathanprozzi
ENG-4659 feat(portal): set up hydration boundary (#898)
2a47620 
- Adds in the HydrationBoundary in the providers.tsx -- this enables the
partial hydration pattern referenced in
#885
- Once this wraps Portal via the providers we can partially hydrate as
long as the queryKey matches server + client side. This won't have any
bearing on our client-side only hooks such as in modals but enables the
hydration pattern where loaders are available
- The HydrationBoundary ensures that our client-side cache for each
query (where loaders are available) starts with the same data that was
fetched and rendered on the server
- Note: This re-opens PR #888 into `feature/graphql-migration` instead
of onto `main`
jonathanprozzi added a commit that referenced this pull request Nov 12, 2024
@jonathanprozzi
ENG-4659 feat(portal): set up hydration boundary (#898)
841e347 
- Adds in the HydrationBoundary in the providers.tsx -- this enables the
partial hydration pattern referenced in
#885
- Once this wraps Portal via the providers we can partially hydrate as
long as the queryKey matches server + client side. This won't have any
bearing on our client-side only hooks such as in modals but enables the
hydration pattern where loaders are available
- The HydrationBoundary ensures that our client-side cache for each
query (where loaders are available) starts with the same data that was
fetched and rendered on the server
- Note: This re-opens PR #888 into `feature/graphql-migration` instead
of onto `main`
Vitalsine85 pushed a commit that referenced this pull request Nov 13, 2024
@jonathanprozzi @Vitalsine85
ENG-4659 feat(portal): set up hydration boundary (#898)
6462ef1 
- Adds in the HydrationBoundary in the providers.tsx -- this enables the
partial hydration pattern referenced in
#885
- Once this wraps Portal via the providers we can partially hydrate as
long as the queryKey matches server + client side. This won't have any
bearing on our client-side only hooks such as in modals but enables the
hydration pattern where loaders are available
- The HydrationBoundary ensures that our client-side cache for each
query (where loaders are available) starts with the same data that was
fetched and rendered on the server
- Note: This re-opens PR #888 into `feature/graphql-migration` instead
of onto `main`
jonathanprozzi added a commit that referenced this pull request Nov 14, 2024
@jonathanprozzi
ENG-4659 feat(portal): set up hydration boundary (#898)
39b3c09 
- Adds in the HydrationBoundary in the providers.tsx -- this enables the
partial hydration pattern referenced in
#885
- Once this wraps Portal via the providers we can partially hydrate as
long as the queryKey matches server + client side. This won't have any
bearing on our client-side only hooks such as in modals but enables the
hydration pattern where loaders are available
- The HydrationBoundary ensures that our client-side cache for each
query (where loaders are available) starts with the same data that was
fetched and rendered on the server
- Note: This re-opens PR #888 into `feature/graphql-migration` instead
of onto `main`
0xjojikun pushed a commit that referenced this pull request Nov 15, 2024
@jonathanprozzi @0xjojikun
ENG-4659 feat(portal): set up hydration boundary (#898)
f544a7b 
- Adds in the HydrationBoundary in the providers.tsx -- this enables the
partial hydration pattern referenced in
#885
- Once this wraps Portal via the providers we can partially hydrate as
long as the queryKey matches server + client side. This won't have any
bearing on our client-side only hooks such as in modals but enables the
hydration pattern where loaders are available
- The HydrationBoundary ensures that our client-side cache for each
query (where loaders are available) starts with the same data that was
fetched and rendered on the server
- Note: This re-opens PR #888 into `feature/graphql-migration` instead
of onto `main`
0xjojikun pushed a commit that referenced this pull request Nov 22, 2024
@jonathanprozzi @0xjojikun
ENG-4659 feat(portal): set up hydration boundary (#898)
088aeb7 
- Adds in the HydrationBoundary in the providers.tsx -- this enables the
partial hydration pattern referenced in
#885
- Once this wraps Portal via the providers we can partially hydrate as
long as the queryKey matches server + client side. This won't have any
bearing on our client-side only hooks such as in modals but enables the
hydration pattern where loaders are available
- The HydrationBoundary ensures that our client-side cache for each
query (where loaders are available) starts with the same data that was
fetched and rendered on the server
- Note: This re-opens PR #888 into `feature/graphql-migration` instead
of onto `main`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xjojikun 0xjojikun 0xjojikun approved these changes

Assignees
No one assigned
Labels
feat Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanprozzi @0xjojikun