Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-4389 feat(portal,1ui): list card & carousel for featured lists #901

Merged

Conversation

Vitalsine85
Copy link
Member

@Vitalsine85 Vitalsine85 commented Nov 12, 2024

Affected Packages

Apps

  • data populator
  • portal
  • template

Packages

  • 1ui
  • api
  • graphql
  • protocol
  • sdk

Tools

  • tools

Overview

  • Added ListCard and ExploreListGrid to 1ui
  • Updated ListGrid in 1ui
  • Added FeaturedListCard and FeaturedListCarousel to Portal
  • Updated ListCard and ExploreListGrid implementations in Portal
  • Modified Avatar in 1ui so that the image size is more responsive due to increased image sizes on ListCard, etc.

Screen Captures

I'll record a Loom tomorrow!

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

Copy link

linear bot commented Nov 12, 2024

@github-actions github-actions bot added the feat Feature label Nov 12, 2024
@@ -0,0 +1,22 @@
import * as React from 'react'

export interface ExploreListGridProps
Copy link
Member

@jonathanprozzi jonathanprozzi Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming question on this @Vitalsine85 @0xjojikun -- do we want to call this something specific like Explore_ instead of a more generic name? Only reason I'm thinking about that is that this could be more generally useful for devs outside of the specific Explore usecase

Not a big deal by any means -- mainly something for us to think about as we create and name additional 1ui components

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was actually thinking of just removing it from 1ui actually, since it is very specific to Portal. They already have ListGrid which serves the same purpose, we just needed another version for Explore because there were issues with how the grid was rendering from one page to another.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense! That's likely the best approach if we don't really need it in 1ui and since it's Portal specific we can have it be there

Copy link
Member

@jonathanprozzi jonathanprozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read through everything and it looks good! I think a Loom or quick demo would be helpful with some context from the Figma

Nice work! 🔥

@jonathanprozzi jonathanprozzi changed the title ENG-4389 feat(portal,1ui): list card & carousal for featured lists ENG-4389 feat(portal,1ui): list card & carousel for featured lists Nov 12, 2024
Copy link
Member

@jonathanprozzi jonathanprozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Vitalsine85 Vitalsine85 force-pushed the vital/eng-4389-list-card-carousal-for-featured-lists branch from 92111c8 to a01f377 Compare November 12, 2024 21:01
@Vitalsine85 Vitalsine85 enabled auto-merge (squash) November 12, 2024 21:04
@Vitalsine85 Vitalsine85 merged commit f47e621 into main Nov 12, 2024
3 checks passed
@Vitalsine85 Vitalsine85 deleted the vital/eng-4389-list-card-carousal-for-featured-lists branch November 12, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants